From: wanghaibin <wanghaibin.wang@huawei.com> To: <linux-kernel@vger.kernel.org> Cc: <tj@kernel.org>, <jiangshanlai@gmail.com>, <peter.huangpeng@huawei.com>, wanghaibin <wanghaibin.wang@huawei.com> Subject: [RFC PATCH 1/4] workqueue: move the wq_update_unbound_numa_attrs_buf allocation location. Date: Thu, 7 Jan 2016 20:38:56 +0800 [thread overview] Message-ID: <1452170339-26748-2-git-send-email-wanghaibin.wang@huawei.com> (raw) In-Reply-To: <1452170339-26748-1-git-send-email-wanghaibin.wang@huawei.com> the wq_update_unbound_numa_attrs_buf will be useful, only when the wq_numa_enabled is true. if there is something wrong to cause the wq_numa_enable false, it can just return without the wq_update_unbound_numa_attrs_buf allocation. This doesn't introduce any functional changes. Signed-off-by: wanghaibin <wanghaibin.wang@huawei.com> --- kernel/workqueue.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index c579dba..d6cbe3d 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -5180,9 +5180,6 @@ static void __init wq_numa_init(void) return; } - wq_update_unbound_numa_attrs_buf = alloc_workqueue_attrs(GFP_KERNEL); - BUG_ON(!wq_update_unbound_numa_attrs_buf); - /* * We want masks of possible CPUs of each node which isn't readily * available. Build one from cpu_to_node() which should have been @@ -5207,6 +5204,9 @@ static void __init wq_numa_init(void) wq_numa_possible_cpumask = tbl; wq_numa_enabled = true; + + wq_update_unbound_numa_attrs_buf = alloc_workqueue_attrs(GFP_KERNEL); + BUG_ON(!wq_update_unbound_numa_attrs_buf); } static int __init init_workqueues(void) -- 1.8.3.1
next prev parent reply other threads:[~2016-01-07 12:40 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-01-07 12:38 [RFC PATCH 0/4] fixs/suggestions for workqueue subsystem wanghaibin 2016-01-07 12:38 ` wanghaibin [this message] 2016-01-07 15:48 ` [RFC PATCH 1/4] workqueue: move the wq_update_unbound_numa_attrs_buf allocation location Tejun Heo 2016-01-11 5:21 ` wanghaibin 2016-01-07 12:38 ` [RFC PATCH 2/4] workqueue: free the allocated memory resource when wq_numa_init failed wanghaibin 2016-01-07 15:50 ` Tejun Heo 2016-01-11 4:26 ` wanghaibin 2016-01-07 12:38 ` [RFC PATCH 3/4] workqueue: remove the unbind workqueue attr sys_file before unregister the workqueue device wanghaibin 2016-01-07 16:00 ` Tejun Heo 2016-01-11 12:23 ` wanghaibin 2016-01-07 12:38 ` [RFC PATCH 4/4] workqueue: simplify the apply_workqueue_attrs_locked function wanghaibin 2016-01-07 16:07 ` Tejun Heo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1452170339-26748-2-git-send-email-wanghaibin.wang@huawei.com \ --to=wanghaibin.wang@huawei.com \ --cc=jiangshanlai@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=peter.huangpeng@huawei.com \ --cc=tj@kernel.org \ --subject='Re: [RFC PATCH 1/4] workqueue: move the wq_update_unbound_numa_attrs_buf allocation location.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).