From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
To: Kamil Debski <k.debski@samsung.com>,
"'Wu-Cheng Li'" <wuchengli@chromium.org>,
pawel@osciak.com, mchehab@osg.samsung.com, hverkuil@xs4all.nl,
crope@iki.fi, standby24x7@gmail.com, ricardo.ribalda@gmail.com,
ao2@ao2.it, bparrot@ti.com
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org
Subject: Re: [PATCH] v4l: add V4L2_CID_MPEG_VIDEO_FORCE_FRAME_TYPE.
Date: Thu, 14 Jan 2016 10:02:23 -0500 [thread overview]
Message-ID: <1452783743.10009.18.camel@collabora.com> (raw)
In-Reply-To: <003f01d14e21$78f7ad40$6ae707c0$@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1166 bytes --]
Hi Kamil,
Le mercredi 13 janvier 2016 à 17:43 +0100, Kamil Debski a écrit :
> Good to hear that there are new codecs to use the V4L2 codec API :)
>
> My two cents are following - when you add a control that does the same work
> as a driver specific control then it would be great if you modified the
> driver that
> uses the specific control to also support the newly added control.
> This way future applications could use the control you added for both new
> and
> old drivers.
When i first notice this MFC specific control, I believed it was use to
produce I-Frame only streams (rather then a toggle, to produce one key-
frame on demand). So I wanted to verify the implementation to make sure
what Wu-Cheng is doing make sense. Though, I found that we set:
ctx->force_frame_type = ctrl->val;
And never use that value anywhere else in the driver code. Hopefully
I'm just missing something, but if it's not implemented, maybe it's
better not to expose it. Otherwise, this may lead to hard to find
streaming issues. I do hope we can add this feature though, as it's
very useful feature for real time encoding.
cheers,
Nicolas
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2016-01-14 15:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 12:03 [PATCH] v4l: add V4L2_CID_MPEG_VIDEO_FORCE_FRAME_TYPE Wu-Cheng Li
2016-01-13 12:03 ` Wu-Cheng Li
2016-01-13 16:43 ` Kamil Debski
2016-01-14 15:02 ` Nicolas Dufresne [this message]
2016-01-14 17:21 ` Kamil Debski
2016-01-14 19:02 ` Nicolas Dufresne
2016-01-15 17:01 ` Kamil Debski
2016-01-15 17:21 ` Nicolas Dufresne
2016-01-13 15:02 ` Nicolas Dufresne
2016-01-13 16:07 ` Wu-Cheng Li (李務誠)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452783743.10009.18.camel@collabora.com \
--to=nicolas.dufresne@collabora.com \
--cc=ao2@ao2.it \
--cc=bparrot@ti.com \
--cc=crope@iki.fi \
--cc=hverkuil@xs4all.nl \
--cc=k.debski@samsung.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=pawel@osciak.com \
--cc=ricardo.ribalda@gmail.com \
--cc=standby24x7@gmail.com \
--cc=wuchengli@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).