From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756217AbcANWaw (ORCPT ); Thu, 14 Jan 2016 17:30:52 -0500 Received: from mail-bn1bon0093.outbound.protection.outlook.com ([157.56.111.93]:26560 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754342AbcANWat (ORCPT ); Thu, 14 Jan 2016 17:30:49 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Aravind.Gopalakrishnan@amd.com; From: Aravind Gopalakrishnan To: , , , , CC: , , , Aravind Gopalakrishnan Subject: [PATCH 2/5] x86/mcheck/AMD: Do not perform shared bank check for future processors Date: Thu, 14 Jan 2016 16:05:37 -0600 Message-ID: <1452809140-3328-3-git-send-email-Aravind.Gopalakrishnan@amd.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1452809140-3328-1-git-send-email-Aravind.Gopalakrishnan@amd.com> References: <1452809140-3328-1-git-send-email-Aravind.Gopalakrishnan@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BY1PR15CA0039.namprd15.prod.outlook.com (25.162.17.177) To BLUPR12MB0418.namprd12.prod.outlook.com (25.162.92.11) X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0418;2:mS2MGl2JdHT45CZ7NDe9FgDyMm4ofwNAsHOWhc+ZTDDk3DggexhIXY0jQ+Qc9Xn3/tEWa99aALJ4/6M1DFS1OYTT1RxIHEhQ7kwGhISoQV7LL7B6dOxWDJ7CxQVE4PQVvd4d3X+YseHdP23E/9g5+Q==;3:I6C4oe9qex9NZcsU6DBR2u8xmf2YyLkL5OSrj44gDitMbirpqUME7Y7PDKLJLfOLBTHMVafzXpceqAA94h50rfa/GV4XOSYFNaQHFj3AVPtaIHT25Rx5gNe+W7pfENQh;25:+3iwNPlmY1OH2WpKGMjlcmfCA/tE+ZRNuf8Fvq2iEjFIdcxSBvM4Qe7QkAGDbmPoHDumrKI0d9P0bU2Sjp5nBHdtfc0QuuhsQvhToSR3aXQqD3xYzU1p9IF18oCICwvuxXgErFaytPy5CrWbF3OG2lzY6Eok2bBY9FdA1VGu6oRyKz+84FZCzYzXftSboe7a1sICNK099bSexiJONEiaFzkI5hrH/2YC8SE6Hw0vvC01KsVC6VEEcmlJyvVlsmEX X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0418; X-MS-Office365-Filtering-Correlation-Id: d25d7d91-7a93-4439-d44a-08d31d2dba62 X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0418;20:3CeooBK2hF709pfGuPxbNEuYVM/bD0QqTzsRSul18BH9rf1qyn+ZpjaXy5m5S8FpDAp4THu319B+U6p8P67NzayeLi+p0muFneZvOcDgvWa1ai1FAxey+btVg98uZgkyzWqx+9nFj9DiQAIR2ijl4+0VK9Dilpi83X8nGyzHxmmBBRQmt6QHGcSoEZIsYMjytaMjnGXheJgRiJl4tt6TN45bNb+w7FMFLCBWTLNym/DPNh9IEaB5/r7filXAHXGHtflWD1poHlgQI/PgsE4dbXyxRSZVZNEUK6Zr7VSS9IERIbcrAEOaNa8DL4hlr6VI6a7t+aqnhcDunFkoFiNp2fR3t/hWgO0Huux8INuTwS86zR0jEJzslBrmF0i166hCtS1PhnsOR357jNcas2Fs6EtMgEaJyVNiHGEu1iBO0tWFdoJL1nM7ZDzV46JuZcIdn+OREdwN5/pLAfrQUR3K6o5yvjg6TcmOb7OLWIZa1Ra9fgQPLt+pPgV6eqdvEzhr;4:cgyK1THxOmiYNeMq2yihrvcaoEnOYJCNaM9qZFGbKKNdWoRDJB0AbAZO0aiz1/KaDwCZV4gIlshh9d2pMxVFAiUGA1NpHBhVup3MhAlXWgZ02t1BaJCJS2q8SiVIul6q/+AxiUdc7GuNLZM+eo3rP7lF3FyvSlNVgVhQLtYCvx20461n4TOF7IqkDmaeDc58CXltVscWGxvLKXyXKVxQFhxi+8QBldg65ECcdfFC2eI7tv2a1DYMPaoNo9OBTOgfQWinDz+wBAuvGK5QKhhufZVvOEf754A/t8BwiDmrw8g6o4KSj0080QZ2/d7WpHZHDUqyL01MtRv7Lg985ExJr28hgqjpko0FNLe52qLPch6NgnSnwspO7zezs5k72lrL4bVLNJclL1A+xoNRLu1UvwvRQLzpSLENsPu7M6DJ1lE= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(10201501046)(3002001);SRVR:BLUPR12MB0418;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0418; X-Forefront-PRVS: 08213D42D3 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(189002)(199003)(86362001)(19580395003)(19580405001)(36756003)(53416004)(106356001)(92566002)(586003)(3846002)(4326007)(1096002)(5003940100001)(2906002)(6116002)(105586002)(5004730100002)(5008740100001)(42186005)(47776003)(5001770100001)(189998001)(66066001)(2201001)(50226001)(77096005)(122386002)(40100003)(76176999)(101416001)(50466002)(97736004)(229853001)(48376002)(2950100001)(87976001)(50986999);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR12MB0418;H:arav-dinar.amd.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BLUPR12MB0418;23:X9ywJMfj2+ojkS/GKpx405pFmKS5DONb2LXFIWdAG?= =?us-ascii?Q?l6icvdxfOqqJZo0SA7btiEwD8cz2uRPv7k7RSRANNoucTdc81/IE9AP6XFh0?= =?us-ascii?Q?4JdXkKbNjhZs0DXFEegixpJHN6amnrnqLfcjwWgQRVF1tAbFLN3wl5Exk9DG?= =?us-ascii?Q?/GYEiURNlqkT2d4vvE7UeB98jiHjkpLY5x3EBY7rCtxyD2Vhs0QjpwUMhAds?= =?us-ascii?Q?Kkt9Ar5bwRMnscB1scrIggJZyYjy922lxZfc6pku8XVCYH+gs+YlaWzZvknN?= =?us-ascii?Q?tJwJXKTIgU075G81ERC4ul4EdN0UfC6hsxkM5elqEywtGTtpnDp0tcGk8Jzq?= =?us-ascii?Q?WX15T+VS6zUOdH7WL7Mb5TciLP6r8olblXjyZ7cwrlJmzsKvb0EPbH7UcBqA?= =?us-ascii?Q?2yzO0gGcHQDKB4J9nS20tGjiDRth8cTrkdoZGjKWdE0LK3vZCqREc09t52Cn?= =?us-ascii?Q?DPphvUg4KQKA7leU3B2pwLQ6IzpM30miguXIULQCNFyVn6P8kTNmFfIa6YOK?= =?us-ascii?Q?wg+K9un7YC0yfzVl76qEPIoLf6siyb5EtZ8W/Zhnkf9tgNxSvZkhcwSycd5n?= =?us-ascii?Q?oiQyvFaPfvKGoixf4WpgBhRWxpItbMmeRN1y2d/CR1GKNPDCZJHbHhRmEVFv?= =?us-ascii?Q?JUKgHBLGV7VfTKIBH/90/PRXsvFGEuz1OFI/EJcvIHypgYcl523WXFXWAPCJ?= =?us-ascii?Q?3qR2DY8zpsoRhsZiJf9vI+tniIpgBZbrBvCka+YUZFaJTNmgv9bGG80pjPKv?= =?us-ascii?Q?ckwvTUwoxQwXFLJWq0eWdXeNbJOTQhm5057zARVQkLXsEyTkcMByY25tdt/L?= =?us-ascii?Q?GDUhYTfIYmE4YF/n7wby+ueKwUUfTMiAFky+NOtcEhGl5cyvMulSPyqHOq40?= =?us-ascii?Q?kMPMQOQDgWCwAfcNQ1f2i69l6DT+Xk833ECdnoX5SluTR3vRJnkoibKRVY0B?= =?us-ascii?Q?5rEQrHukLYoUrt/sifdGRIOGENXk6i7NhX/uqJ2isgIxKroHn8tlL3O/vhc/?= =?us-ascii?Q?FLFHtdQ6dgg3QX35fJpUq1DBBnEjXurwsO4oPFNM5cglA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0418;5:5hHY/dvjTISkNJmus5KfeatmlqnSm8IYewIcq8fhXzHrh3SsBLSulJPo0xGl1HAgIJHiKI0jEKugCEl5ZTg+OegY0ISknyLSF6/msMNZJd3mCWYnTqVN+RYtAiB8Uj1WdOnUoGul9c4/9s5X8zVDdg==;24:la93D6dwiBzKn+b3JABhX6qUbkJZ/3xgGWXn1ZbMBm7IAZewAsTre6EJ24Ezt3t4b2Czz9+qtbMHi4Pt99/qD9NmzGuXysSU9mPr5OYIfHQ=;20:a4f1h7TPo/RerP3cuxF8jy++mi7CUT518qtqjfaVa8e74uxnH8DjLkAbUPgoSRCvm/STLD3HCkbQZx14kCOGLKOsduTxiJ43ZgQ5NPmK/3YtZxFRJYSNTsGK9l7rh0ilsF43muAM1LVPh16Gzzd2JAsAHh3Mxadtz1MzoKt1OHHW2ijHaVFyqHXPK+/9hSl0oxFU2h20yrnkKk2Gc01e0yVgsw1Q05HZzbMVq+kjQIMuUDPxJ1sK6lbOI9qJkypF X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2016 21:57:41.1988 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR12MB0418 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fam17h and above should not require a check to see if a bank is shared or not. For shared banks, there will always be only one core that has visibility over the MSRs and only that particular core will be allowed to write to the MSRs Fixing the code to return early if we detect Fam17h or above. No change in functionality for earlier processors Signed-off-by: Aravind Gopalakrishnan --- arch/x86/kernel/cpu/mcheck/mce_amd.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/x86/kernel/cpu/mcheck/mce_amd.c b/arch/x86/kernel/cpu/mcheck/mce_amd.c index e99b150..da570a8 100644 --- a/arch/x86/kernel/cpu/mcheck/mce_amd.c +++ b/arch/x86/kernel/cpu/mcheck/mce_amd.c @@ -84,6 +84,14 @@ struct thresh_restart { static inline bool is_shared_bank(int bank) { + /* + * For Fam17h and above, we shouldn't require this check. + * Only the core that can see valid values on the MSRs has + * control over the respective MCA bank + */ + if (mce_flags.smca) + return 0; + /* Bank 4 is for northbridge reporting and is thus shared */ return (bank == 4); } -- 2.7.0