From: Andi Kleen <andi@firstfloor.org>
To: acme@kernel.org
Cc: peterz@infradead.org, jolsa@kernel.org, eranian@google.com,
linux-kernel@vger.kernel.org, mingo@kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 04/11] perf, tools, stat: Avoid fractional digits for integer scales
Date: Fri, 15 Jan 2016 17:12:46 -0800 [thread overview]
Message-ID: <1452906773-7581-5-git-send-email-andi@firstfloor.org> (raw)
In-Reply-To: <1452906773-7581-1-git-send-email-andi@firstfloor.org>
From: Andi Kleen <ak@linux.intel.com>
When the scaling factor is a full integer don't display fractional
digits. This avoids unnecessary .00 output for topdown metrics
with scale factors.
v2: Remove redundant check.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
tools/perf/builtin-stat.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index d20cf3e..dca4f0d 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -66,6 +66,7 @@
#include <stdlib.h>
#include <sys/prctl.h>
#include <locale.h>
+#include <math.h>
#define DEFAULT_SEPARATOR " "
#define CNTR_NOT_SUPPORTED "<not supported>"
@@ -967,12 +968,12 @@ static void abs_printout(int id, int nr, struct perf_evsel *evsel, double avg)
const char *fmt;
if (csv_output) {
- fmt = sc != 1.0 ? "%.2f%s" : "%.0f%s";
+ fmt = floor(sc) != sc ? "%.2f%s" : "%.0f%s";
} else {
if (big_num)
- fmt = sc != 1.0 ? "%'18.2f%s" : "%'18.0f%s";
+ fmt = floor(sc) != sc ? "%'18.2f%s" : "%'18.0f%s";
else
- fmt = sc != 1.0 ? "%18.2f%s" : "%18.0f%s";
+ fmt = floor(sc) != sc ? "%18.2f%s" : "%18.0f%s";
}
aggr_printout(evsel, id, nr);
--
2.4.3
next prev parent reply other threads:[~2016-01-16 1:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-16 1:12 Add top down metrics to perf stat Andi Kleen
2016-01-16 1:12 ` [PATCH 01/11] perf, tools: Dont stop PMU parsing on alias parse error Andi Kleen
2016-01-16 1:12 ` [PATCH 02/11] perf, tools: Parse an .aggr-per-core event attribute Andi Kleen
2016-01-16 1:12 ` [PATCH 03/11] perf, tools, stat: Force --per-core mode for .aggr-per-core aliases Andi Kleen
2016-01-16 1:12 ` Andi Kleen [this message]
2016-01-16 1:12 ` [PATCH 05/11] perf, tools, stat: Scale values by unit before metrics Andi Kleen
2016-01-16 1:12 ` [PATCH 06/11] perf, tools, stat: Basic support for TopDown in perf stat Andi Kleen
2016-01-16 1:12 ` [PATCH 07/11] perf, tools, stat: Add computation of TopDown formulas Andi Kleen
2016-01-16 1:12 ` [PATCH 08/11] perf, tools, stat: Add extra output of counter values with -v Andi Kleen
2016-01-16 1:12 ` [PATCH 09/11] x86, perf: Support sysfs files depending on SMT status Andi Kleen
2016-01-18 18:03 ` Peter Zijlstra
2016-01-18 18:06 ` Peter Zijlstra
2016-01-18 22:28 ` Andi Kleen
2016-01-16 1:12 ` [PATCH 10/11] x86, perf: Add Top Down events to Intel Core Andi Kleen
2016-01-16 1:12 ` [PATCH 11/11] x86, perf: Add Top Down events to Intel Atom Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452906773-7581-5-git-send-email-andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).