From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936474AbcJRQYJ (ORCPT ); Tue, 18 Oct 2016 12:24:09 -0400 Received: from ducie-dc1.codethink.co.uk ([185.25.241.215]:59870 "EHLO ducie-dc1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933386AbcJRQXa (ORCPT ); Tue, 18 Oct 2016 12:23:30 -0400 Subject: Re: [Linux-kernel] [PATCH] tty: serial: 8250: add CON_CONSDEV to flags To: Jiri Slaby , Matthew Leach , Greg Kroah-Hartman , Jiri Slaby References: <1466522389-26943-1-git-send-email-matthew.leach@codethink.co.uk> <40b80b82-531d-d9e8-0b4d-bdd559ad5044@suse.cz> Cc: linux-kernel@lists.codethink.co.uk, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org From: Ben Dooks Organization: Codethink Limited. Message-ID: <1452ffb1-429b-65e8-3c5d-76a03ea4eb4a@codethink.co.uk> Date: Tue, 18 Oct 2016 17:23:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <40b80b82-531d-d9e8-0b4d-bdd559ad5044@suse.cz> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/10/16 17:15, Jiri Slaby wrote: > On 06/21/2016, 05:19 PM, Matthew Leach wrote: >> When using the 8250 as a boot console and the main console results in >> messages being printed twice. The console framework will only >> unregister boot consoles if a new console is registered with the >> CON_CONSDEV flag set. >> >> Set this flag for the univ8250 console to prevent double-registration. >> >> Signed-off-by: Matthew Leach >> --- >> drivers/tty/serial/8250/8250_core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c >> index 2f4f5ee..7a7453d 100644 >> --- a/drivers/tty/serial/8250/8250_core.c >> +++ b/drivers/tty/serial/8250/8250_core.c >> @@ -675,7 +675,7 @@ static struct console univ8250_console = { >> .device = uart_console_device, >> .setup = univ8250_console_setup, >> .match = univ8250_console_match, >> - .flags = CON_PRINTBUFFER | CON_ANYTIME, >> + .flags = CON_PRINTBUFFER | CON_ANYTIME | CON_CONSDEV, > > This patch breaks console= parameter handling. Passing: > console=ttyS0 console=tty0 > no longer means /dev/console is tty0 and it should be as is documented. > > I have not investigated further yet. Ok, thanks. I'll need to find Matthew Leach's new address as he's moved jobs. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius