From: "Neftin, Sasha" <sasha.neftin@intel.com>
To: Chen Zhou <chenzhou10@huawei.com>,
jeffrey.t.kirsher@intel.com, davem@davemloft.net
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH next] igc: make non-global functions static
Date: Wed, 26 Feb 2020 15:32:37 -0800 [thread overview]
Message-ID: <1453037a-4370-8c08-f8c9-dfaa629e96b0@intel.com> (raw)
In-Reply-To: <20200108133959.93035-1-chenzhou10@huawei.com>
On 1/8/2020 05:39, Chen Zhou wrote:
> Fix sparse warning:
> drivers/net/ethernet/intel/igc/igc_ptp.c:512:6:
> warning: symbol 'igc_ptp_tx_work' was not declared. Should it be static?
> drivers/net/ethernet/intel/igc/igc_ptp.c:644:6:
> warning: symbol 'igc_ptp_suspend' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> ---
> drivers/net/ethernet/intel/igc/igc_ptp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_ptp.c b/drivers/net/ethernet/intel/igc/igc_ptp.c
> index 6935065..389a969 100644
> --- a/drivers/net/ethernet/intel/igc/igc_ptp.c
> +++ b/drivers/net/ethernet/intel/igc/igc_ptp.c
> @@ -509,7 +509,7 @@ static void igc_ptp_tx_hwtstamp(struct igc_adapter *adapter)
> * This work function polls the TSYNCTXCTL valid bit to determine when a
> * timestamp has been taken for the current stored skb.
> */
> -void igc_ptp_tx_work(struct work_struct *work)
> +static void igc_ptp_tx_work(struct work_struct *work)
> {
> struct igc_adapter *adapter = container_of(work, struct igc_adapter,
> ptp_tx_work);
> @@ -641,7 +641,7 @@ void igc_ptp_init(struct igc_adapter *adapter)
> * This function stops the overflow check work and PTP Tx timestamp work, and
> * will prepare the device for OS suspend.
> */
> -void igc_ptp_suspend(struct igc_adapter *adapter)
> +static void igc_ptp_suspend(struct igc_adapter *adapter)
> {
> if (!(adapter->ptp_flags & IGC_PTP_ENABLED))
> return;
>
This patch should be partially reverted for "igc_ptp_suspend".
"igc_ptp_suspend" declared in igc.h file and used in "__igc_shutdown"
method.
prev parent reply other threads:[~2020-02-26 23:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 13:39 [PATCH next] igc: make non-global functions static Chen Zhou
2020-02-01 1:58 ` Brown, Aaron F
2020-02-26 23:32 ` Neftin, Sasha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453037a-4370-8c08-f8c9-dfaa629e96b0@intel.com \
--to=sasha.neftin@intel.com \
--cc=chenzhou10@huawei.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).