From: Andi Kleen <andi@firstfloor.org>
To: acme@kernel.org
Cc: jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org,
eranian@google.com, Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 03/12] perf, tools, stat: Force --per-core mode for .aggr-per-core aliases
Date: Tue, 19 Jan 2016 18:27:35 -0800 [thread overview]
Message-ID: <1453256864-24192-4-git-send-email-andi@firstfloor.org> (raw)
In-Reply-To: <1453256864-24192-1-git-send-email-andi@firstfloor.org>
From: Andi Kleen <ak@linux.intel.com>
When an event alias is used that the kernel marked as .aggr-per-core, force
--per-core mode (and also require -a and forbid cgroups or per thread mode).
This in term means, --topdown forces --per-core mode.
This is needed for TopDown in SMT mode, because it needs to measure
all threads in a core together and merge the values to compute the correct
percentages of how the pipeline is limited.
We do this if any alias is aggr-per-core.
The main stat code does the necessary checks and forces per core mode.
v2: Rename agg-per-core to aggr-per-core
v3: Split patch into parse and use
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
tools/perf/builtin-stat.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index b6dcafa..72bc9b4 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -2135,6 +2135,7 @@ static int __cmd_report(int argc, const char **argv)
int cmd_stat(int argc, const char **argv, const char *prefix __maybe_unused)
{
+ struct perf_evsel *counter;
const char * const stat_usage[] = {
"perf stat [<options>] [<command>]",
NULL
@@ -2276,6 +2277,23 @@ int cmd_stat(int argc, const char **argv, const char *prefix __maybe_unused)
if (add_default_attributes())
goto out;
+ evlist__for_each (evsel_list, counter) {
+ /* Enable per core mode if only a single event requires it. */
+ if (counter->aggr_per_core) {
+ if (stat_config.aggr_mode != AGGR_GLOBAL &&
+ stat_config.aggr_mode != AGGR_CORE) {
+ pr_err("per core event configuration requires per core mode\n");
+ goto out;
+ }
+ stat_config.aggr_mode = AGGR_CORE;
+ if (nr_cgroups || !target__has_cpu(&target)) {
+ pr_err("per core event configuration requires system-wide mode (-a)\n");
+ goto out;
+ }
+ break;
+ }
+ }
+
target__validate(&target);
if (perf_evlist__create_maps(evsel_list, &target) < 0) {
--
2.4.3
next prev parent reply other threads:[~2016-01-20 2:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 2:27 Add top down metrics to perf stat Andi Kleen
2016-01-20 2:27 ` [PATCH 01/12] perf, tools: Dont stop PMU parsing on alias parse error Andi Kleen
2016-01-20 2:27 ` [PATCH 02/12] perf, tools: Parse an .aggr-per-core event attribute Andi Kleen
2016-01-20 2:27 ` Andi Kleen [this message]
2016-01-20 2:27 ` [PATCH 04/12] perf, tools, stat: Avoid fractional digits for integer scales Andi Kleen
2016-01-20 2:27 ` [PATCH 05/12] perf, tools, stat: Scale values by unit before metrics Andi Kleen
2016-01-20 2:27 ` [PATCH 06/12] perf, tools, stat: Basic support for TopDown in perf stat Andi Kleen
2016-01-20 2:27 ` [PATCH 07/12] perf, tools, stat: Add computation of TopDown formulas Andi Kleen
2016-01-20 2:27 ` [PATCH 08/12] perf, tools, stat: Add extra output of counter values with -v Andi Kleen
2016-01-20 2:27 ` [PATCH 09/12] x86, perf: Support sysfs files depending on SMT status Andi Kleen
2016-01-20 2:27 ` [PATCH 10/12] x86, perf: Add Top Down events to Intel Core Andi Kleen
2016-01-20 2:27 ` [PATCH 11/12] x86, perf: Add Top Down events to Intel Atom Andi Kleen
2016-01-20 2:27 ` [PATCH 12/12] x86, perf: Use new ht_on flag in HT leak workaround Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453256864-24192-4-git-send-email-andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).