From: <mika.penttila@nextfour.com>
To: <linux-kernel@vger.kernel.org>
Cc: linux-mm@kvack.org, rientjes@google.com, linux@arm.linux.org.uk,
"Mika Penttilä" <mika.penttila@nextfour.com>
Subject: [PATCH 4/4] make apply_to_page_range() more robust.
Date: Sat, 23 Jan 2016 17:05:43 +0200 [thread overview]
Message-ID: <1453561543-14756-5-git-send-email-mika.penttila@nextfour.com> (raw)
In-Reply-To: <1453561543-14756-1-git-send-email-mika.penttila@nextfour.com>
From: Mika Penttilä <mika.penttila@nextfour.com>
Now the arm/arm64 don't trigger this BUG_ON() any more,
but WARN_ON() is here enough to catch buggy callers
but still let potential other !size callers pass with warning.
Signed-off-by: Mika Penttilä mika.penttila@nextfour.com
---
mm/memory.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/mm/memory.c b/mm/memory.c
index 30991f8..9178ee6 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1871,7 +1871,9 @@ int apply_to_page_range(struct mm_struct *mm, unsigned long addr,
unsigned long end = addr + size;
int err;
- BUG_ON(addr >= end);
+ if (WARN_ON(addr >= end))
+ return -EINVAL;
+
pgd = pgd_offset(mm, addr);
do {
next = pgd_addr_end(addr, end);
--
1.9.1
next prev parent reply other threads:[~2016-01-23 15:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 15:05 [PATCH 0/4] set_memory_xx fixes mika.penttila
2016-01-23 15:05 ` [PATCH 1/4] arm: Fix wrong bounds check mika.penttila
2016-01-25 18:37 ` Laura Abbott
2016-01-23 15:05 ` [PATCH 2/4] arm: let set_memory_xx(addr, 0) succeed mika.penttila
2016-01-25 18:41 ` Laura Abbott
2016-01-23 15:05 ` [PATCH 3/4] arm64: " mika.penttila
2016-01-25 18:44 ` Laura Abbott
2016-01-26 2:34 ` David Rientjes
2016-01-23 15:05 ` mika.penttila [this message]
2016-01-26 2:32 ` [PATCH 4/4] make apply_to_page_range() more robust David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453561543-14756-5-git-send-email-mika.penttila@nextfour.com \
--to=mika.penttila@nextfour.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).