From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754421AbcAWSOR (ORCPT ); Sat, 23 Jan 2016 13:14:17 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:36018 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753345AbcAWSOO (ORCPT ); Sat, 23 Jan 2016 13:14:14 -0500 Message-ID: <1453572839.3734.170.camel@decadent.org.uk> Subject: Re: [PATCH 2.6.32 40/42] mm/memory_hotplug.c: check for missing sections in test_pages_in_a_zone() From: Ben Hutchings To: Willy Tarreau , linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Andrew Banman , Alex Thorlton , Russ Anderson , Yinghai Lu , Greg KH , Seth Jennings , Andrew Morton , Linus Torvalds Date: Sat, 23 Jan 2016 18:13:59 +0000 In-Reply-To: <20160123141223.715609509@1wt.eu> References: <20160123141223.715609509@1wt.eu> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-UavxfH1w2Q6Qw14sy7Mh" X-Mailer: Evolution 3.18.3-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 192.168.4.247 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-UavxfH1w2Q6Qw14sy7Mh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2016-01-23 at 15:13 +0100, Willy Tarreau wrote: > 2.6.32-longterm review patch.=C2=A0=C2=A0If anyone has any objections, pl= ease let me know. >=20 > ------------------ >=20 > From: Andrew Banman >=20 > commit 5f0f2887f4de9508dcf438deab28f1de8070c271 upstream. [...] > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index f4be464..de19654 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -601,23 +601,30 @@ int is_mem_section_removable(unsigned long start_pf= n, unsigned long nr_pages) > =C2=A0 */ > =C2=A0static int test_pages_in_a_zone(unsigned long start_pfn, unsigned l= ong end_pfn) > =C2=A0{ > - unsigned long pfn; > + unsigned long pfn, sec_end_pfn; > =C2=A0 struct zone *zone =3D NULL; > =C2=A0 struct page *page; > =C2=A0 int i; > - for (pfn =3D start_pfn; > + for (pfn =3D start_pfn, sec_end_pfn =3D SECTION_ALIGN_UP(start_pfn); [...] SECTION_ALIGN_UP() is not defined in 2.6.32; it was added by commit a539f3533b78. Ben. --=20 Ben Hutchings Life is what happens to you while you're busy making other plans. - John Lenno= n --=-UavxfH1w2Q6Qw14sy7Mh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUAVqPC6Oe/yOyVhhEJAQqRFxAAnH0BrxTiNwDoEiH6PMdLx2P6tFZaoB8x tQsJlRkOJp+WZ/V3Kl0/y3EK+I8b2BFIvCuKrYQFxsx3mX7i+DTtNWMo0drbqOC/ 3jwTzuEyXINN/kx51BVbiX8rtg3b+QZn7d0Y4JtlYa988XS1c4XJpXBLdJMCIP2p 1VJUbRUgYxkylP0MjYqKrowXnGGIDTfU4CSCkSJHPwSCtXR5QqbQ52kdR/ize8Pt rkLNAB4iSG8Bega0wpGfhWnJxlL5/Rh5IgwR6/afIgvr9P1RONhI94CXY9EJZAsn 3vZBJ1UvW7pQQUf+9/DRHXOVh/5idlJNky5PIFwk+I1Mj4VBUwdeVwAxLUMeHJ44 9y+T7d9FEuOgEhd8lu1rgV55ICJ07Z40lqzvA6uPK84qrkQxiNKilRsZwBNLdNMr 6J5C/UrWVjGQqheYEZDWzsrZldLc/j0hxxYxgCXGKxi6HmrZXI6A0rKsIECQMfpd jz1voJwdMCYPp3rQ+gjX2jG4cu4HUU/RYOIt4gDLkdyZEwZ/TfVikMz71MheolrF PuffegdkH5hHfE8VfnH7LiHZ1ujYjmCSjyepWepXREdgXASyybN8CMwc44CFknjU RzRFq6Mnlq6y4lwh+vXmTPXvFrH82wJnJYC2w6keYlEh9TA8GpnYR+NfXUYYNSWF 2L2kz3qMAz8= =Pbil -----END PGP SIGNATURE----- --=-UavxfH1w2Q6Qw14sy7Mh--