From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Matt Fleming <matt@codeblueprint.co.uk>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
linux-efi@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel @ vger . kernel . org"
<linux-kernel@vger.kernel.org>, Robert Elliott <elliott@hpe.com>
Subject: Re: [PATCH v3 3/4] x86/efi: print size in binary units in efi_print_memmap
Date: Mon, 25 Jan 2016 07:25:34 -0800 [thread overview]
Message-ID: <1453735534.2363.7.camel@HansenPartnership.com> (raw)
In-Reply-To: <1453710713.2521.200.camel@linux.intel.com>
On Mon, 2016-01-25 at 10:31 +0200, Andy Shevchenko wrote:
> On Sat, 2016-01-23 at 10:03 -0800, James Bottomley wrote:
> > On Sat, 2016-01-23 at 19:18 +0200, Andy Shevchenko wrote:
> > > > If the goal is to have a clean interface reporting only the
> > > > first
> > > > four significant figures and a size exponent, then a helper
> > > > would
> > > > be much better than trying to open code this ad hoc.
> > >
> > > No. You get it wrong. The initial idea was (actually not mine,
> > > see
> > > authorship) to print an exact number with units and reduce
> > > whenever
> > > it's possible, i.e number is a multiplication of certain unit.
> >
> > so you must implement the original idea no matter how inconsistent
> > it
> > leads us to be? Is it wrong to try to do better?
>
> For both comments I prefer to hear Matt's opinion as he is maintainer
> of EFI stuff.
>
> My role in this all is to reduce the code base by avoiding 'not
> invented here' syndrome.
To get up to the starting blocks on that one, you need a usable
interface. Neither of the series has that for lib/string_helper.c, so
this is a NAK to both of those parts.
I already told you how to do it in a way that creates a maintainable
interface. It looks obvious to me and I was politely waiting for you
to produce it, but if you're saying your not able to, I suppose I can
produce the patch.
James
next prev parent reply other threads:[~2016-01-25 15:25 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 14:55 [PATCH v3 0/4] x86/efi: use binary units when printing Andy Shevchenko
2016-01-23 14:55 ` [PATCH v3 1/4] lib/string_helpers: export string_units_{2,10} for others Andy Shevchenko
2016-01-23 16:14 ` James Bottomley
2016-01-23 16:58 ` Andy Shevchenko
2016-01-23 14:55 ` [PATCH v3 2/4] lib/string_helpers: fix indentation in few places Andy Shevchenko
2016-01-23 14:55 ` [PATCH v3 3/4] x86/efi: print size in binary units in efi_print_memmap Andy Shevchenko
2016-01-23 16:44 ` James Bottomley
2016-01-23 17:18 ` Andy Shevchenko
2016-01-23 18:03 ` James Bottomley
2016-01-25 8:31 ` Andy Shevchenko
2016-01-25 15:25 ` James Bottomley [this message]
2016-01-23 18:12 ` James Bottomley
2016-01-23 20:29 ` One Thousand Gnomes
2016-01-23 20:43 ` H. Peter Anvin
2016-01-25 18:02 ` Elliott, Robert (Persistent Memory)
2016-01-25 18:56 ` James Bottomley
2016-01-25 19:28 ` Andy Shevchenko
2016-01-25 19:45 ` James Bottomley
2016-01-25 20:01 ` Andy Shevchenko
2016-01-25 20:18 ` James Bottomley
2016-01-25 20:37 ` Elliott, Robert (Persistent Memory)
2016-01-26 11:50 ` Matt Fleming
2016-01-26 11:59 ` Andy Shevchenko
2016-01-28 9:29 ` Matt Fleming
2016-01-28 11:15 ` Andy Shevchenko
2016-01-25 20:44 ` James Bottomley
2016-01-23 14:55 ` [PATCH v3 4/4] x86/efi: Use proper units in efi_find_mirror() Andy Shevchenko
2016-01-23 16:34 ` [PATCH v3 0/4] x86/efi: use binary units when printing James Bottomley
2016-01-23 17:20 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453735534.2363.7.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=elliott@hpe.com \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).