* [PATCH V2 1/1] scsi: storvsc: Fix a build issue reported by kbuild test robot
@ 2016-01-30 3:36 K. Y. Srinivasan
2016-01-30 5:36 ` James Bottomley
0 siblings, 1 reply; 2+ messages in thread
From: K. Y. Srinivasan @ 2016-01-30 3:36 UTC (permalink / raw)
To: gregkh, linux-kernel, devel, ohering, James.Bottomley, hch,
linux-scsi, apw, vkuznets, jasowang, martin.petersen, hare
Cc: K. Y. Srinivasan
tree: https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgit.kernel.org%2fpub%2fscm%2flinux%2fkernel%2fgit%2ftorvalds%2flinux.git&data=01%7c01%7ckys%40microsoft.com%7ce2e0622715844b79ad7108d32796ec3c%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=ubr4GbBaNS%2ftOz%2buJBk0CL9N0UNG9x2TidLgy6Yovg4%3d master
head: 03c21cb775a313f1ff19be59c5d02df3e3526471
commit: dac582417bc449b1f7f572d3f1dd9d23eec15cc9 storvsc: Properly support Fibre Channel devices
date: 3 weeks ago
config: x86_64-randconfig-s3-01281016 (attached as .config)
reproduce:
git checkout dac582417bc449b1f7f572d3f1dd9d23eec15cc9
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/built-in.o: In function `storvsc_remove':
>> storvsc_drv.c:(.text+0x213af7): undefined reference to `fc_remove_host'
drivers/built-in.o: In function `storvsc_drv_init':
>> storvsc_drv.c:(.init.text+0xcbcc): undefined reference to `fc_attach_transport'
>> storvsc_drv.c:(.init.text+0xcc06): undefined reference to `fc_release_transport'
drivers/built-in.o: In function `storvsc_drv_exit':
>> storvsc_drv.c:(.exit.text+0x123c): undefined reference to `fc_release_transport'
With this commit, the storvsc driver depends on FC atttributes. Make this
dependency explicit.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
---
V2: Fixed the dependency based on suggestion by James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/scsi/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 64eed87..ce0d07b 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -594,6 +594,7 @@ config XEN_SCSI_FRONTEND
config HYPERV_STORAGE
tristate "Microsoft Hyper-V virtual storage driver"
depends on SCSI && HYPERV
+ depends on SCSI_FC_ATTRS || SCSI_FC_ATTRS !=m
default HYPERV
help
Select this option to enable the Hyper-V virtual storage driver.
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V2 1/1] scsi: storvsc: Fix a build issue reported by kbuild test robot
2016-01-30 3:36 [PATCH V2 1/1] scsi: storvsc: Fix a build issue reported by kbuild test robot K. Y. Srinivasan
@ 2016-01-30 5:36 ` James Bottomley
0 siblings, 0 replies; 2+ messages in thread
From: James Bottomley @ 2016-01-30 5:36 UTC (permalink / raw)
To: K. Y. Srinivasan, gregkh, linux-kernel, devel, ohering, hch,
linux-scsi, apw, vkuznets, jasowang, martin.petersen, hare
On Fri, 2016-01-29 at 19:36 -0800, K. Y. Srinivasan wrote:
> tree: https://na01.safelinks.protection.outlook.com/?url=https%3a%2
> f%2fgit.kernel.org%2fpub%2fscm%2flinux%2fkernel%2fgit%2ftorvalds%2fli
> nux.git&data=01%7c01%7ckys%40microsoft.com%7ce2e0622715844b79ad7108d3
> 2796ec3c%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=ubr4GbBaNS%2ftO
> z%2buJBk0CL9N0UNG9x2TidLgy6Yovg4%3d master
> head: 03c21cb775a313f1ff19be59c5d02df3e3526471
> commit: dac582417bc449b1f7f572d3f1dd9d23eec15cc9 storvsc: Properly
> support Fibre Channel devices
> date: 3 weeks ago
> config: x86_64-randconfig-s3-01281016 (attached as .config)
> reproduce:
> git checkout dac582417bc449b1f7f572d3f1dd9d23eec15cc9
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
>
> drivers/built-in.o: In function `storvsc_remove':
> > > storvsc_drv.c:(.text+0x213af7): undefined reference to
> > > `fc_remove_host'
> drivers/built-in.o: In function `storvsc_drv_init':
> > > storvsc_drv.c:(.init.text+0xcbcc): undefined reference to
> > > `fc_attach_transport'
> > > storvsc_drv.c:(.init.text+0xcc06): undefined reference to
> > > `fc_release_transport'
> drivers/built-in.o: In function `storvsc_drv_exit':
> > > storvsc_drv.c:(.exit.text+0x123c): undefined reference to
> > > `fc_release_transport'
>
> With this commit, the storvsc driver depends on FC atttributes. Make
> this
> dependency explicit.
>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> V2: Fixed the dependency based on suggestion by James Bottomley
> <James.Bottomley@HansenPartnership.com>
>
> drivers/scsi/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 64eed87..ce0d07b 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -594,6 +594,7 @@ config XEN_SCSI_FRONTEND
> config HYPERV_STORAGE
> tristate "Microsoft Hyper-V virtual storage driver"
> depends on SCSI && HYPERV
> + depends on SCSI_FC_ATTRS || SCSI_FC_ATTRS !=m
No ... if you want to depend on the FC_ATTRS then a simple depend
works. If you want to be able to build without them or with them, then
that line must read
depends on m || SCSI_FC_ATTRS != m
James
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-30 5:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-30 3:36 [PATCH V2 1/1] scsi: storvsc: Fix a build issue reported by kbuild test robot K. Y. Srinivasan
2016-01-30 5:36 ` James Bottomley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).