From: Andreas Kemnade <andreas@kemnade.info>
To: libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, hns@goldelico.com
Cc: Andreas Kemnade <andreas@kemnade.info>
Subject: [PATCH v3 3/6] libertas: do not confirm sleep if commands are pending
Date: Sat, 30 Jan 2016 18:01:53 +0100 [thread overview]
Message-ID: <1454173316-13444-4-git-send-email-andreas@kemnade.info> (raw)
In-Reply-To: <1454173316-13444-1-git-send-email-andreas@kemnade.info>
If the main thread gets one PS AWAKE event and one PS SLEEP event
in one iteration over event_fifo there will never be checks for
commands to be processed, since psstate will always be
PS_STATE_SLEEP or PS_STATE_PRE_SLEEP
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
changes in v3: corrected paths
changes in v2: reordered: was 4/6
drivers/net/wireless/marvell/libertas/cmdresp.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/wireless/marvell/libertas/cmdresp.c b/drivers/net/wireless/libertas/cmdresp.c
index 701125f..c95bf6d 100644
--- a/drivers/net/wireless/marvell/libertas/cmdresp.c
+++ b/drivers/net/wireless/marvell/libertas/cmdresp.c
@@ -257,6 +257,10 @@ int lbs_process_event(struct lbs_private *priv, u32 event)
"EVENT: in FULL POWER mode, ignoring PS_SLEEP\n");
break;
}
+ if (!list_empty(&priv->cmdpendingq)) {
+ lbs_deb_cmd("EVENT: commands in queue, do not sleep\n");
+ break;
+ }
priv->psstate = PS_STATE_PRE_SLEEP;
lbs_ps_confirm_sleep(priv);
--
2.1.4
next prev parent reply other threads:[~2016-01-30 17:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-30 17:01 [PATCH v3 0/6] libertas: ieee80211 powersave mode Andreas Kemnade
2016-01-30 17:01 ` [PATCH v3 1/6] libertas: fix pointer bugs for PS_MODE commands Andreas Kemnade
2016-02-06 12:02 ` [v3,1/6] " Kalle Valo
2016-01-30 17:01 ` [PATCH v3 2/6] libertas: check whether bus can do more than polling Andreas Kemnade
2016-01-30 17:01 ` Andreas Kemnade [this message]
2016-01-30 17:01 ` [PATCH v3 4/6] libertas: go back to ps mode without commands pending Andreas Kemnade
2016-01-30 17:01 ` [PATCH v3 5/6] libertas: fix ps-mode related removal problems Andreas Kemnade
2016-01-30 17:01 ` [PATCH v3 6/6] libertas: add an cfg80211 interface for powersaving Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454173316-13444-4-git-send-email-andreas@kemnade.info \
--to=andreas@kemnade.info \
--cc=hns@goldelico.com \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).