From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932399AbcA3RDA (ORCPT ); Sat, 30 Jan 2016 12:03:00 -0500 Received: from smtprelay0239.hostedemail.com ([216.40.44.239]:41629 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754194AbcA3RCS (ORCPT ); Sat, 30 Jan 2016 12:02:18 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1981:2194:2198:2199:2200:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3653:3865:3866:3867:3868:3870:3872:3874:4321:5007:6261:10004:10400:10450:10455:10848:11026:11232:11658:11783:11914:12043:12114:12438:12517:12519:12740:13069:13311:13357:13894:14659:19904:19999:21080:30012:30054:30064:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: sky37_30df698395b2c X-Filterd-Recvd-Size: 2322 Message-ID: <1454173334.7329.14.camel@perches.com> Subject: Re: [PATCH 1/2] staging:iio:adc:added space around '-' From: Joe Perches To: Dan Carpenter , Jonathan Cameron Cc: Lars-Peter Clausen , devel@driverdev.osuosl.org, Michael.Hennerich@analog.com, linux-iio@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, Bhumika Goyal Date: Sat, 30 Jan 2016 09:02:14 -0800 In-Reply-To: <20160130151213.GC13219@mwanda> References: <115dd2e3f67706fd323c18b23871068ad36dfa94.1452878721.git.bhumirks@gmail.com> <56995378.1010204@metafoo.de> <20160120142137.GC6370@mwanda> <56A4FD7F.6010800@kernel.org> <56A5068D.4080207@metafoo.de> <56ACC4D2.8040802@kernel.org> <20160130151213.GC13219@mwanda> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2016-01-30 at 18:12 +0300, Dan Carpenter wrote: > We could make checkpatch.pl not complain if the line says checkpatch: > on > it.  It would look like this. > > -               in_voltage-voltage_thresh_low_value, > +               in_voltage-voltage_thresh_low_value, /* checkpatch: > not math */ > > I suppose I could have made the explanation longer since the it won't > complain about the 80 character limit...  What do yo/u guys think? Maybe use a more generic thing like the checkpatch type                in_voltage-voltage_thresh_low_value, /* checkpatch-SPACING */ Even so, it might uglify checkpatch code a lot to check something like this per-line or per-block. And that likely would have to be per line in the code as checkpatch couldn't see when a patch block addition occurs outside the scope of a comment. I suppose inside checkpatch the "sub report {" function could be extended to look at the specific $rawline being tested for any "checkpatch" comment and if so, test if it's the specific $type.