linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>,
	Andi Kleen <andi@firstfloor.org>, David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Wang Nan <wangnan0@huawei.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 03/10] perf report: Apply --percent-limit to callchains also
Date: Mon,  1 Feb 2016 18:49:12 -0300	[thread overview]
Message-ID: <1454363359-27435-4-git-send-email-acme@kernel.org> (raw)
In-Reply-To: <1454363359-27435-1-git-send-email-acme@kernel.org>

See http://www.infradead.org/rpr.html

From: Namhyung Kim <namhyung@kernel.org>

Currently --percent-limit option only works for hist entries.  However
it'd be better to have same effect to callchains as well

Requested-by: Andi Kleen <andi@firstfloor.org>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1453909257-26015-4-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-report.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 2bf537f190a0..72ed0b46d5a1 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -75,7 +75,10 @@ static int report__config(const char *var, const char *value, void *cb)
 		return 0;
 	}
 	if (!strcmp(var, "report.percent-limit")) {
-		rep->min_percent = strtof(value, NULL);
+		double pcnt = strtof(value, NULL);
+
+		rep->min_percent = pcnt;
+		callchain_param.min_percent = pcnt;
 		return 0;
 	}
 	if (!strcmp(var, "report.children")) {
@@ -633,8 +636,10 @@ parse_percent_limit(const struct option *opt, const char *str,
 		    int unset __maybe_unused)
 {
 	struct report *rep = opt->value;
+	double pcnt = strtof(str, NULL);
 
-	rep->min_percent = strtof(str, NULL);
+	rep->min_percent = pcnt;
+	callchain_param.min_percent = pcnt;
 	return 0;
 }
 
-- 
2.5.0

  parent reply	other threads:[~2016-02-01 21:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-01 21:49 [GIT PULL 00/10] perf/core callchains improvements and fixes Arnaldo Carvalho de Melo
2016-02-01 21:49 ` [PATCH 01/10] perf hists: Fix min callchain hits calculation Arnaldo Carvalho de Melo
2016-02-01 21:49 ` [PATCH 02/10] perf hists: Update hists' total period when adding entries Arnaldo Carvalho de Melo
2016-02-01 21:49 ` Arnaldo Carvalho de Melo [this message]
2016-02-01 21:49 ` [PATCH 04/10] perf report: Get rid of hist_entry__callchain_fprintf() Arnaldo Carvalho de Melo
2016-02-01 21:49 ` [PATCH 05/10] perf callchain: Pass parent_samples to __callchain__fprintf_graph() Arnaldo Carvalho de Melo
2016-02-01 21:49 ` [PATCH 06/10] perf report: Fix percent display in callchains on --stdio Arnaldo Carvalho de Melo
2016-02-01 21:49 ` [PATCH 07/10] perf hists browser: Fix dump to show correct callchain style Arnaldo Carvalho de Melo
2016-02-01 21:49 ` [PATCH 08/10] perf hists browser: Pass parent_total to callchain print functions Arnaldo Carvalho de Melo
2016-02-01 21:49 ` [PATCH 09/10] perf hists browser: Fix percent display in callchains Arnaldo Carvalho de Melo
2016-02-01 21:49 ` [PATCH 10/10] perf report: Don't show blank lines if entry has no callchain Arnaldo Carvalho de Melo
2016-02-03 10:04 ` [GIT PULL 00/10] perf/core callchains improvements and fixes Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2016-01-27 15:40 [PATCHSET 00/10] perf tools: Apply percent-limit to callchains (v2) Namhyung Kim
2016-01-27 15:40 ` [PATCH 03/10] perf report: Apply --percent-limit to callchains also Namhyung Kim
2016-02-01 20:19   ` Arnaldo Carvalho de Melo
2016-02-02 13:05     ` Namhyung Kim
2016-02-02 13:55       ` Arnaldo Carvalho de Melo
2016-02-02 14:15         ` Namhyung Kim
2016-02-02 14:27           ` Arnaldo Carvalho de Melo
2016-02-02 14:35             ` Namhyung Kim
2016-02-02 14:57               ` Arnaldo Carvalho de Melo
2016-02-02 15:03                 ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454363359-27435-4-git-send-email-acme@kernel.org \
    --to=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=andi@firstfloor.org \
    --cc=dsahern@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).