From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753569AbcBCJmT (ORCPT ); Wed, 3 Feb 2016 04:42:19 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:18376 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751346AbcBCJmO (ORCPT ); Wed, 3 Feb 2016 04:42:14 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Wed, 03 Feb 2016 01:42:15 -0800 From: Laxman Dewangan To: , , , CC: , , , Laxman Dewangan Subject: [PATCH V2 2/5] rtc: max77686: use rtc regmap to access RTC registers Date: Wed, 3 Feb 2016 15:00:45 +0530 Message-ID: <1454491848-26551-3-git-send-email-ldewangan@nvidia.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1454491848-26551-1-git-send-email-ldewangan@nvidia.com> References: <1454491848-26551-1-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org rtc_regmap should be used to access all RTC registers instead of parent regmap regardless of what chip or property have it. This makes the register access uniform and extendible for other chips. Signed-off-by: Laxman Dewangan CC: Krzysztof Kozlowski CC: Javier Martinez Canillas Tested-by: Krzysztof Kozlowski Reviewed-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- Changes from V1: None, added reviewed/tested by. drivers/rtc/rtc-max77686.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index 253cf12..11f74ed 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -370,7 +370,7 @@ static int max77686_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) goto out; } - ret = regmap_read(info->max77686->regmap, + ret = regmap_read(info->max77686->rtc_regmap, map[REG_RTC_AE1], &val); if (ret < 0) { dev_err(info->dev, @@ -426,7 +426,8 @@ static int max77686_rtc_stop_alarm(struct max77686_rtc_info *info) goto out; } - ret = regmap_write(info->max77686->regmap, map[REG_RTC_AE1], 0); + ret = regmap_write(info->max77686->rtc_regmap, + map[REG_RTC_AE1], 0); } else { ret = regmap_bulk_read(info->max77686->rtc_regmap, map[REG_ALARM1_SEC], data, @@ -471,7 +472,7 @@ static int max77686_rtc_start_alarm(struct max77686_rtc_info *info) goto out; if (info->drv_data->alarm_enable_reg) { - ret = regmap_write(info->max77686->regmap, map[REG_RTC_AE1], + ret = regmap_write(info->max77686->rtc_regmap, map[REG_RTC_AE1], MAX77802_ALARM_ENABLE_VALUE); } else { ret = regmap_bulk_read(info->max77686->rtc_regmap, -- 2.1.4