From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755550AbcBCLJk (ORCPT ); Wed, 3 Feb 2016 06:09:40 -0500 Received: from smtprelay0059.hostedemail.com ([216.40.44.59]:35427 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751762AbcBCLJi (ORCPT ); Wed, 3 Feb 2016 06:09:38 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::,RULES_HIT:41:69:355:379:541:599:800:960:967:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1431:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2525:2561:2564:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3354:3622:3653:3865:3866:3867:3868:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4321:5007:6261:7576:7974:9025:10004:10400:10450:10455:10848:11026:11232:11473:11658:11783:11914:12043:12048:12291:12296:12346:12438:12517:12519:12555:12679:12683:12740:13161:13229:13894:14096:14097:14659:19904:19999:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:11,LUA_SUMMARY:none X-HE-Tag: sugar49_70d22f068aa2d X-Filterd-Recvd-Size: 3603 Message-ID: <1454497774.7291.73.camel@perches.com> Subject: Re: [PATCH 10/14] efi: Make checkpatch complain less about efi.h GUID additions From: Joe Perches To: Ingo Molnar , Matt Fleming , Andrew Morton , Andy Whitcroft , Dan Carpenter Cc: "H . Peter Anvin" , Thomas Gleixner , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Jones , Ard Biesheuvel Date: Wed, 03 Feb 2016 03:09:34 -0800 In-Reply-To: <20160203103335.GA7310@gmail.com> References: <1454364428-494-1-git-send-email-matt@codeblueprint.co.uk> <1454364428-494-11-git-send-email-matt@codeblueprint.co.uk> <20160203103335.GA7310@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-02-03 at 11:33 +0100, Ingo Molnar wrote: > * Matt Fleming wrote: > > > From: Peter Jones > > > > This reformats the GUID definitions in include/linux/efi.h so that if > > you add another one with the same style, checkpatch won't complain about > > it. > > > > Signed-off-by: Peter Jones > > Cc: Ard Biesheuvel > > Signed-off-by: Matt Fleming > > --- > >  include/linux/efi.h | 63 +++++++++++++++++++++++++++++++++++------------------ > >  1 file changed, 42 insertions(+), 21 deletions(-) > > > > diff --git a/include/linux/efi.h b/include/linux/efi.h > > index 09f1559e7525..f468f7c53236 100644 > > --- a/include/linux/efi.h > > +++ b/include/linux/efi.h > > @@ -535,67 +535,88 @@ void efi_native_runtime_setup(void); > >   *  EFI Configuration Table and GUID definitions > >   */ > >  #define NULL_GUID \ > > -    EFI_GUID(  0x00000000, 0x0000, 0x0000, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 ) > > + EFI_GUID(0x00000000, 0x0000, 0x0000, \ > > +  0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00) > >   > >  #define MPS_TABLE_GUID    \ > > -    EFI_GUID(  0xeb9d2d2f, 0x2d88, 0x11d3, 0x9a, 0x16, 0x0, 0x90, 0x27, 0x3f, 0xc1, 0x4d ) > > + EFI_GUID(0xeb9d2d2f, 0x2d88, 0x11d3, \ > > +  0x9a, 0x16, 0x00, 0x90, 0x27, 0x3f, 0xc1, 0x4d) > > So I really think this is a step backwards. Some people take checkpatch messages altogether too seriously. from: https://lkml.org/lkml/2015/7/16/568 ---------------------------------- The other thing that might help is for people to take the warnings the script produces less seriously. Maybe convert: ERROR -> defect WARNING -> unstylish CHECK -> nitpick or some such ---------------------------------- > Checkpatch should be fixed/enhanced to allow targeted exemption. Something like: > > > #define CHECKPATCH_IGNORE > ... > #undef CHECKPATCH_IGNORE > > ... which checkpatch would parse and interpret accordingly. A similar proposal: https://lkml.org/lkml/2016/1/30/175 checkpatch works on patches. If the #define isn't in the patch scope the script won't know. Perhaps it's simpler to add some facility to allow lines with known keywords to exceed $max_line_length similar to the format strings of logging functions.