From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756100AbcBDGyL (ORCPT ); Thu, 4 Feb 2016 01:54:11 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:11593 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751755AbcBDGyJ (ORCPT ); Thu, 4 Feb 2016 01:54:09 -0500 Message-ID: <1454568843.15541.1.camel@mtksdaap41> Subject: Re: [PATCH v6] i2c: mt8173: add 4GB mode support in i2c driver. From: Yingjoe Chen To: Liguo Zhang CC: Wolfram Sang , Xudong Chen , , Sascha Hauer , , , , "Matthias Brugger" , Eddie Huang , Date: Thu, 4 Feb 2016 14:54:03 +0800 In-Reply-To: <1454347143-31461-1-git-send-email-liguo.zhang@mediatek.com> References: <1454347143-31461-1-git-send-email-liguo.zhang@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-02-02 at 01:19 +0800, Liguo Zhang wrote: > If 4GB mode is enable, we should add 4gb mode support in i2c driver. > Set 4GB mode register to support 4GB mode. > > Signed-off-by: Liguo Zhang > --- > change in v6: > Remove unnecessary init for reg_4g_mode. > change in v5: > Use BIT_ULL() to fix kernel building warning. > change in v4: > Use BIT_ULL() to fix kernel building warning. > change in v3: > Only inline the computation of reg_4g_mode in mtk_i2c_set_4g_mode(). > change in v2: > Define a static inline function mtk_i2c_set_4g_mode() for support 4g mode. > --- > drivers/i2c/busses/i2c-mt65xx.c | 42 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 42 insertions(+) Looks good to me, Thanks. Reviewed-by: Yingjoe Chen Joe.C