From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750966AbcBKBXn (ORCPT ); Wed, 10 Feb 2016 20:23:43 -0500 Received: from smtprelay0049.hostedemail.com ([216.40.44.49]:53274 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750765AbcBKBXm (ORCPT ); Wed, 10 Feb 2016 20:23:42 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:800:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1567:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3867:3870:4321:5007:6261:10004:10400:10848:11026:11232:11658:11914:12114:12296:12438:12517:12519:12740:13069:13311:13357:14659:21080:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: tub24_774c6d1aa815e X-Filterd-Recvd-Size: 1445 Message-ID: <1455153818.3333.55.camel@perches.com> Subject: Re: [PATCH 2/4] acct,time: change indentation in __acct_update_integrals From: Joe Perches To: riel@redhat.com, linux-kernel@vger.kernel.org Cc: fweisbec@gmail.com, tglx@linutronix.de, mingo@kernel.org, luto@amacapital.net, peterz@infradead.org, clark@redhat.com, eric.dumazet@gmail.com Date: Wed, 10 Feb 2016 17:23:38 -0800 In-Reply-To: <1455152907-18495-3-git-send-email-riel@redhat.com> References: <1455152907-18495-1-git-send-email-riel@redhat.com> <1455152907-18495-3-git-send-email-riel@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-02-10 at 20:08 -0500, riel@redhat.com wrote: > Change the indentation in __acct_update_integrals to make the function > a little easier to read. trivia: > diff --git a/kernel/tsacct.c b/kernel/tsacct.c [] > @@ -125,31 +125,32 @@ void xacct_add_tsk(struct taskstats *stats, struct task_struct *p) [] > + if (!likely(tsk->mm)) > + return; Using if (unlikely(!tsk->mm)) return; would be a lot more common. (~150:1 in the kernel sources)