From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932087AbcBKJQm (ORCPT ); Thu, 11 Feb 2016 04:16:42 -0500 Received: from mail-by2on0077.outbound.protection.outlook.com ([207.46.100.77]:5600 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753242AbcBKJQf (ORCPT ); Thu, 11 Feb 2016 04:16:35 -0500 Authentication-Results: 8bytes.org; dkim=none (message not signed) header.d=none;8bytes.org; dmarc=none action=none header.from=amd.com; From: Suravee Suthikulpanit To: , , , , CC: , , , Suravee Suthikulpanit Subject: [PATCH V4 6/6] perf/amd/iommu: Clean up print messages pr_debug Date: Thu, 11 Feb 2016 16:15:27 +0700 Message-ID: <1455182127-17551-7-git-send-email-Suravee.Suthikulpanit@amd.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1455182127-17551-1-git-send-email-Suravee.Suthikulpanit@amd.com> References: <1455182127-17551-1-git-send-email-Suravee.Suthikulpanit@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [124.121.8.20] X-ClientProxiedBy: SINPR01CA0021.apcprd01.prod.exchangelabs.com (10.141.109.21) To BLUPR12MB0435.namprd12.prod.outlook.com (25.162.92.140) X-MS-Office365-Filtering-Correlation-Id: 8e268f6f-b6d0-4e79-4919-08d332c404be X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0435;2:G1Babmv/aaslsyux18j+/NqZ9o+Bts24ZT29CtCxft14ggXHsiWazd2u92bTkI8hrNgOjiD2HP1gcNys4XvcOghQP19WkSZ8IHklSJuPkVwsm1KTGgD03M+cWg+ozhD8YJWANvY8urCVjbLZy4oACsJwJh2bdG4YhHfKiF/EClHIana0nKBThkURO7GBb0g6;3:1I9JZsW5MfOOUSI93mY85Rxay7Le/W8080nL03ha7xfDjeXNQTvAM6Y5V6qpjhX5ILgHEg7O9S9heP64frJ8PYZuviM9AIcg+3OZXFVuj/pZ9B4OEQWKYJF9fcHnZ2Dj;25:HRwfAdXcwtqrvhVAeEw5XplZNVu7V42AKXYDG8erWIb+RxSuWzqVrHeeVTwiwtNnqK3tG+aBfmEJvlMh0fjXOXJ5qqm0wsxNlI91V7zYwtR7L3zcn/7CDtr/oo4cCoeAkhCo3NRveK+JTpOFzhlFY/FM1r8Vqz5WAaas3DC2vP/NXymai9CBEJ3ezcYJxgQFm3WuDCjifksPEd5LUYxhhBJFxBksjkJHCE5OQSBisF0HNz+ZJI9X6Gxbx84utAYM47GYsM9kSgRR+iuvl9R5HNTtEuWxgLcX0C+7nTowt9mUrbQs4r6vrI/hbs1QtE3D X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0435; X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0435;20:MmvBTcCF77i5jQMPvjGpN/UIOvIJrgkUAyH9XwyV/hnnOVVdHvBWbSZvcN+v4RYW4h8sRq5WKXAmPn7QpUDf9rqCHuR1V/JelTqS1BDG/K6uVIkuKR8Cr3gePeugyW9pMauw+NsGmw9oq3M1PkpgsxG00118PPAIqRuv6BZnrtuLIQv5y2m6vR9xhGjuzZNw72I8KasXpcYSdTVtyhjI1pGiRY1Zr1pItI8sHE688wWrKbbDKJGX6kZitmCi4nMn5RYIMceLqKrY4SuW+oGBEPlWpkKY9wv0GWP6Fi9qowbo8OaEkJdb7fEDp55CVIy8TzqyARunQimjBqZ+CbLAAljCbbmvEw0Y/wvpJP3IpUYaB7ndKu73Y6+oSSIfgO/AUytltAhdqKWSz26/NGFDx/uIZqUDQrGRsmyI8PIQ2vupbNaddn8xf+4/jR6UIj8YnY/UL/n8GmIpxOpZTTx15eH6g7qpVRlmgSd6XcU0pUX6yut5hHJ70bJ343AwPWbs;4:1a+lA5dUorbSECPOq9pKSxotX+dte4mxbsSq3sGnPRIlsR8bLlbY+g7vpK4Xd/7eRVevdIeZYarmBbm2x7kry4ZjlyIy8TQJekZ3QjSw+jfGHELQQhydyuwSXGA6tBiR+8IfJBvuaDLqsRQ7PYjc2/zX3DwAlY7fy2T0sa1l758ycoHMjhyUS+HADZDCBYr1kRnGDCIUl3tu6xJMaezjDG3YPxbKfFtq0+s/Q3msWFonvvfnMD2pmkNY0inVshdhXfk0YPYCPOdVgzGLEcOvd2H/5N+T/J4svBMA7qg/Pp7aGOY35hnRXiD/twY2QQAKtvW/3ixnLb1U3Ykh3ag7pFVlg1FcUZFZdy8CwKLNeeBLEACQDhm+HktcWcmyF5h2MNC6G+2WMO3tdvQJMdZk5OJqkmMI4jhSyDsdO7XWV5Q= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:BLUPR12MB0435;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0435; X-Forefront-PRVS: 08497C3D99 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6069001)(6009001)(50986999)(42186005)(5004730100002)(122386002)(2950100001)(19580395003)(77096005)(2906002)(87976001)(40100003)(229853001)(50466002)(2201001)(36756003)(19580405001)(5008740100001)(92566002)(50226001)(47776003)(6116002)(86362001)(66066001)(4326007)(189998001)(3846002)(5001960100002)(76176999)(48376002)(5001770100001)(586003)(1096002);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR12MB0435;H:localhost.localdomain;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0435;23:jiGTyHCUv3SBc8FfvuuskS8nJOqauEzW6C+inha0KzkmDp+VGUnUghmgcDWEIIwIESN9vrHGCZ+NvKkfQt3+DQs00EOTfURtUr07uc4/RshBzORR7ELnEWIvGmqzJSsQxdIjhwboxVsczGBdEVMroJB+tDM/BrCdlKcw5DTPIU4Cx48MOmy+VuX6bFeNGvnsFfVelPmlAFFhwsTaznTsIk2WBqxxQWf7autZnSsRptK4U7HSfAAmSR2jh53bFiJlPXtgy2nXs/BaKPUwuaeTJlvoHKeTod2uX3reZQXvetLwdUQ5XS65BmwYeZlB3pYAn85IoHLDAeCh3AExr3k8V6+Q4BxLm350oqnHlaknuTWGA9y6ObCjAyBlv7Qk24ilAuZeoN074va0w7q2kN6g7yC2iWNWqohttOA5qma8XdHnNl0ge0rKEq+RTeDm9zsCYmIV13s2rIdy4tcf7hWsGigkjrnRRZxuHuphYYgU4rDlKix51CIpHSb3RPpoOVXnqlOjdH3+VwMgSY0QPPC7UbAe1uiwXurXoGtgEB/ETCNvex9E3dlxDq/K1sn91jPLRMd+sY4kTrcCHhF/ZKU7YA1VEFpdTva09JQu8UKqcTR2J/rYamM+jI2z3Xp4uq+BZY0Q9KRX3N3cHWaOASDe4YLsv9TpoDxOqIl+V38f2RrJlEwBX/+c8vmf7mop925PexfmPihwHtZp9qE3UPVbbhgPrmpjBsaNR5+NAGmf9tWOBOH4j20cRiXSK05oT32dGzLf2pWcnvy28MopsdYpsV9OjMKu0S513nYQvSMLvOIMsdYW4ymo2S5aCa0O8BnvlMBpD0UqVCxm1irJMl/s9sBDCl+2PtpT4ZK/I8HejZBgzmFxUhLWHI31cXj2fg45K4P4GsiTGwwjNu0KPAFQNQ== X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0435;5:oWs3Njwdr06RrU49laOkKMm8vwg8DqRnXamezt2lpEkvWcWUPbvdUWnrWb/SudeH234G9Z/F/KhGHcPN+n/1bUzvDGBR77z7ANzF4d+crSytUeppejIcE8EdV18TNbSDojEFYqsi0W2PFv8BW3vbWw==;24:UL9pEWcmeMuxWErVrBRUqZgOJRYaLosgP+pErhAlebRJFfMhFgkstXTJOMg6cN4OZjzOkNJdYDsmdxfq+UR2P9w1y2WrjUyK3tQ58qHCZ00=;20:MPl1VsbxIshQ6K3tPHpIIM4A4Bub4O3DqXUpVn3kOF1vE8evGaVVebTb6EizKtjtGrBAIuGppJOPV9RIQypX/8WMwlIHlWzH/WT+QD4gPWJLNFKaOBK1EuVljWIC2SwPvsOOLCh4kPXEy/Grumvz0F7mJ/SCTscPSMed0SuL+/h+CYRLRFdNvHSNppcEtQ7CETf6/z07vewZKtFSR4v3EqU3cldo1J7vhsYSTZneLhq4UWbM5nTgBzAo2CqgPAip X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2016 09:16:23.2991 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR12MB0435 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Suravee Suthikulpanit This patch declares pr_fmt for perf/amd_iommu, removes unnecessary pr_debug, and clean up error messages. Signed-off-by: Suravee Suthikulpanit --- arch/x86/events/amd/iommu.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/arch/x86/events/amd/iommu.c b/arch/x86/events/amd/iommu.c index 947ae8a..3e00925 100644 --- a/arch/x86/events/amd/iommu.c +++ b/arch/x86/events/amd/iommu.c @@ -11,6 +11,8 @@ * published by the Free Software Foundation. */ +#define pr_fmt(fmt) "perf/amd_iommu: " fmt + #include #include #include @@ -305,7 +307,6 @@ static void perf_iommu_start(struct perf_event *event, int flags) struct perf_amd_iommu, pmu); - pr_debug("perf: amd_iommu:perf_iommu_start\n"); if (WARN_ON_ONCE(!(hwc->state & PERF_HES_STOPPED))) return; @@ -381,8 +382,6 @@ static void perf_iommu_stop(struct perf_event *event, int flags) struct hw_perf_event *hwc = &event->hw; u64 config; - pr_debug("perf: amd_iommu:perf_iommu_stop\n"); - if (hwc->state & PERF_HES_UPTODATE) return; @@ -404,7 +403,6 @@ static int perf_iommu_add(struct perf_event *event, int flags) struct perf_amd_iommu *perf_iommu = container_of(event->pmu, struct perf_amd_iommu, pmu); - pr_debug("perf: amd_iommu:perf_iommu_add\n"); event->hw.state = PERF_HES_UPTODATE | PERF_HES_STOPPED; /* request an iommu bank/counter */ @@ -425,7 +423,6 @@ static void perf_iommu_del(struct perf_event *event, int flags) struct perf_amd_iommu *perf_iommu = container_of(event->pmu, struct perf_amd_iommu, pmu); - pr_debug("perf: amd_iommu:perf_iommu_del\n"); perf_iommu_stop(event, PERF_EF_UPDATE); /* clear the assigned iommu bank/counter */ @@ -489,7 +486,7 @@ static __init int _init_perf_amd_iommu( /* Init events attributes */ if (_init_events_attrs(perf_iommu) != 0) - pr_err("perf: amd_iommu: Only support raw events.\n"); + pr_err("Only support raw events.\n"); perf_iommu->max_banks = amd_iommu_pc_get_max_banks(); perf_iommu->max_counters = amd_iommu_pc_get_max_counters(); @@ -514,10 +511,10 @@ static __init int _init_perf_amd_iommu( ret = perf_pmu_register(&perf_iommu->pmu, name, -1); if (ret) { - pr_err("perf: amd_iommu: Failed to initialized.\n"); + pr_err("Error initializing AMD IOMMU perf counters.\n"); amd_iommu_pc_exit(); } else { - pr_info("perf: amd_iommu: Detected. (%d banks, %d counters/bank)\n", + pr_info("Detected. (%d banks, %d counters/bank)\n", amd_iommu_pc_get_max_banks(), amd_iommu_pc_get_max_counters()); } -- 2.5.0