From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752804AbcBLOAV (ORCPT ); Fri, 12 Feb 2016 09:00:21 -0500 Received: from mail-bn1bon0065.outbound.protection.outlook.com ([157.56.111.65]:27232 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752490AbcBLOAR (ORCPT ); Fri, 12 Feb 2016 09:00:17 -0500 Authentication-Results: 8bytes.org; dkim=none (message not signed) header.d=none;8bytes.org; dmarc=none action=none header.from=amd.com; From: Suravee Suthikulpanit To: , , , CC: , , , , Suravee Suthikulpanit Subject: [PART1 RFC 0/9] KVM: x86: Introduce SVM AVIC support Date: Fri, 12 Feb 2016 20:59:25 +0700 Message-ID: <1455285574-27892-1-git-send-email-suravee.suthikulpanit@amd.com> X-Mailer: git-send-email 2.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [124.121.8.20] X-ClientProxiedBy: SG2PR03CA0036.apcprd03.prod.outlook.com (25.160.233.46) To BY1PR12MB0440.namprd12.prod.outlook.com (25.162.147.141) X-MS-Office365-Filtering-Correlation-Id: 97bb6bf1-3235-4c8c-3c8a-08d333b4d3e8 X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0440;2:U2m+TaFC1rZpxT5etj2aDSKic6D3TajuKrXXEKoYsxRf9wSgBv5JAn9FIenLzz17uE5ax79PCG5EIf6uvJue9SmGoaKknjDw4WULsysQ/xdZ0hWBOnguZPuxM1+Z7U7OoVaTMbQhLh6jYW0lmfnvNCX0dqHRJZwf+AHmM6nD2MXo3IwSMDYYqLrzvqBERGVV;3:97QmRNr30GASpO3m9ME1xH/DcZgQ+1iiZ9/esCF2qvPb2hB74ce56XrqlYuxHopN5PvIrYny9kjXC7jmcpChVDE9Xj7g2Hga1nGPS9slhWS4hP+4LKIET1F/SVHY/0gi;25:tTOkSr9sGxoY6ULP4pztkwhckvt5TttwLdkuBP+MDKYxA5MgkA0sP5qKlG/uZXDm/p3vwHlRtATUQVPcetnibVAwhYlsMgsbev94no4fbYlsBy+VGmqU1JwmQQYi0W2Z5ogFIYzLL8jq42RMmKLCNSJft4reFmaanXs32VGDbWngYBvB5K38+s2SQNNbFW9SkoBC5PFriZRh4RTRkdMz0s+k2RqIAlTF0AzTjXLgUBY/2Imgr8mwQJOabKeLPIEIn6pqpKS1oGU+cKK7rekxQJ9M8QtjKOloEXruA5hBypdIpIeKhTAk+Ln7tmBkBo3Z X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0440; X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0440;20:QHz34xnr+OPtqTjESzNevwXiliiuEI6VEgyZMsuGJKLAT1d3tNuNY76Iu5+Kfu3IHxG2gVpCNpv2Akp/qi5bNmOpY8Iz99mMB5/7Fb4xcvKk7+uvfapNFP0dvvKLa9iOVt7uqM/KFF4uCXgFCfAHw7Gbvnvmo0kY/zSTA3lQr+rZVKoROm14zIX1zRKVKN9p+CD+0nd3lLPcfmqhudS1uHXlNqaW/87AWzuqJTXVOczzo1Ejo0FvFG7nlGXP21hlWRdFemaWWeXDoL1I0XAy6leiQxNJ0L+rgl7YRYjF6qW5kwtp/yM8oSe9R3diSYCaCf6Xn4kxlFmN33dTcgClfE/7TPI2ZBBmvBJQfonE2VOwpRe/+F07PfliXWBIUORMw6s6zhtboz0EinYdDihT9G3QW/dKwcyDVdINGS8kYrAam0UsYv/Kg4CFEqr9fsA6acnDeynqhcUWw93ezn1h9yV9z6tt4I7/LeLmFQYSFQZiozQRNapp5T+MTAC41IMQ;4:ex3RX36iu/ngR8x5+I8Zjie5Sn8tjKFevBtGrzFqaKlznTyOiNZgFerfuSWPw4InMLiQtadr0LAVFtmOq2BZmZF3GrGLh23jBf7OQ2K91wlndRdDNbGJKXyYC89OYCJGrplbWfmDJRuv99K5oro0kJINNuqQ9/0+qx5OZbOx3g+8ir2+Mi1vKiI+KF1ku9po6sUDulzULz2dI7eZduytMkBBmpbO3O77tciX6sOOpmZqiqhqj36mQ0iyOzYDlp75/o4F370ZFrl0MkgUGy3Dx7wPdbLXYAGuv3pDcQ+SxziRj0KrEQNJU0E6BBdVneDY+JUYv9XdSj8Jt2ro6yFCxUq0/M0sjFv0MzA2Kr3MlLTbypeh994QjHxoI6tRmd9UeXqwJtgBW7a/krACUzMk0JVxbTmkhkZcS9JKeAG5SG4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:BY1PR12MB0440;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0440; X-Forefront-PRVS: 0850800A29 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6069001)(243025005)(2201001)(36756003)(15975445007)(586003)(40100003)(92566002)(23676002)(3846002)(77096005)(229853001)(19580395003)(19580405001)(6116002)(2870700001)(5004730100002)(189998001)(4326007)(42186005)(5820100001)(66066001)(50226001)(87976001)(5008740100001)(5001770100001)(15395725005)(122386002)(33646002)(50466002)(50986999)(86362001)(19300405004)(5001960100002)(47776003)(19273905006)(1096002)(2906002)(217873001)(562404015)(563064011);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR12MB0440;H:localhost.localdomain;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjEyTUIwNDQwOzIzOlZ1ZmQrd28wWEk1VFVEWVk5aU5uUGdESFBO?= =?utf-8?B?QXJ4Q3F1Wi96OU5GVTlJVHdWNGtSQ204cmxTV2xJNENvaWh1VVRqa1g4dzlw?= =?utf-8?B?VmZNVHVuN015YzczanZaY25IeUFRbE9uRjhxNW1aUkE0YzdReXJKa1pTQmhY?= =?utf-8?B?d2U1dW9xbVNwTVlZVk9BOUx6SDZPcDY3dzB3V1dIbS9pUGlHbjh3NFB6T0R3?= =?utf-8?B?WlFZbUFGNXBJK0c5b000ajhzTlZsSFp1dURIcU1qSFdsVEMrY1JlV1VFckdJ?= =?utf-8?B?MGhTM2xQeHZaTzRSdXpUc09yWnIwVUFDM2JhRnVCV2NqWmhOTWZOeVNCWTJ6?= =?utf-8?B?MnhmemFYVzBEMm5ZNG56MjJjQWV1Z3VUTG84cVdKWXVhdUNiU1NlL3J3amhR?= =?utf-8?B?cmFIQzBLY3BpOEQzYll2bFJRLzVjdUNCU3Z6Ui9Bb3VsV0N6WVhyWERQakVP?= =?utf-8?B?ZWpTanV1ckRESVNQVk9YaUM3TlVYVE9YaHJLNU82STVjRHMxeWZiMUdINk9T?= =?utf-8?B?UzdUdU10d2MwYjVOT2Ywei90QnhUcjR5cFU4eTczc2NJY3VhNlB4QmlVNis0?= =?utf-8?B?SFMzaWJWZ05YYTBMQ1ZNZ1NMMklBLzh2OGJiRHp0STMzNTZvNzlLNmdzTGE3?= =?utf-8?B?VWRyTEpUVlIrMWFWZkkzL0dKNmlVemtnUXF1emVsMkZKOHBNdWVRWlRMdXZT?= =?utf-8?B?REFwaXIvUWFrU2c0L25ENXpSV3dNRkRVQU1FSmRJQVNacFBCTExYVExhVGMv?= =?utf-8?B?SkpmRmJZOG5PZXlFTlJSZzU4K1N5MEYvcU51MXhlVlhkVTZzVU1SWHFvaWhO?= =?utf-8?B?WXNBdFdCTzlEL2JPV1BTWFRyaVkyd2Q4SUpmK01ZS3dnNGpYTFJJVWxPb2ox?= =?utf-8?B?SmN1dGEyREEyVTFrbm5hdkV3NGtZdjVrV1pMekpIRW1ZQmpYYlhRTlh2YmdT?= =?utf-8?B?SmFzY2o3aCtJTnF3TWpEKzhGMmU4bmE5ZkNGa0tDdkdmbWJVbDJyNkYzTHhn?= =?utf-8?B?VW45QXdxV0RkOVZKYVkrMXpJb21iVi9XN1R1K2ZyK1dmakxmcCtqR3ozdEwx?= =?utf-8?B?bnFyZUk5M2VSSkZmNjJPTUp6WTlzU2lEUkJMYmp0Z1BhNUZocmdSaEtKallG?= =?utf-8?B?OWVocXNPaEYwVWVlaU96Q1JaWVZaenBGQmh1bDdjTEw2Vk1uMXRUY2R1YTRy?= =?utf-8?B?cDF6bGZ4WDJmT0p1ZkpIdmV1WjQ2YkhMQnJjZUNLdit4NkZKK1dRN2tIam5H?= =?utf-8?B?M1Vvc0YvN0RUS2xYVWN4dmU2K0ZKT0FoYi9PWFg0Zy9Sd0ZJZ21IdTBMdUs4?= =?utf-8?B?R1pCOURMVjRSa0o1bWFTSll4ZHZTaTFWR3JtSmYycWtqWGE1V28weWlTcjNa?= =?utf-8?B?NUtac3lpbFpPSk5hT2R6Z0NrZ1FEZ2tHTVpxeTlyUlhxbkZOekNhZm1QSlQz?= =?utf-8?B?L3VxQ2ZnUjI2TGRVUjlXVGFhTVc1TUs1d2plZ1ZadHpDRm5CUmREQ3hPb0Rm?= =?utf-8?Q?OX7XcxRZ8eAE8IohJdV9/35QlLemDMOlXxoo/8vIrAaoRp?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0440;5:CPPN1jAK180y83nvEL+iyMwQ4NaN9HYhzG+2YFtiXF1XCw84VBMiQEMLcxQ7BuhRakjNelw0wCmXACZGEHwsyOR/6nPDtoKjgzpIFblB+oMEBs98SOwlyWM1wtOyPHIEzmbi9iFHJp5l/ENUGrHdKg==;24:8C797doC+xmmG9m/15qE5xJENcHNYqqn7YFBnRsePAqOlK7yy/3JyhBq7vL3Z/DQs//04QZmWi/GgvHB1iwErVTtplysmZ/QYehvHsw+eyA=;20:ByxePRy3KUzISaCdWMlG8SlZ37rinZiDuOIWJlsczSoKDrylss2TaFxZ5N+Hi2Qpr6j4MsAxa/Xf3n7q3mD3XNFfR8PH/N+JgKNRyCMKtc0mS3mRHGFETjZiOs9JthHvsqTRoMkr8EIO89Ey7L0IZuMPD535xXomf11TCS0yLuno6atJncb80ijaUmvM1Y7qWphQVcICaxVizaPTAdYDEzDVj0jJIJvvvQ3FzkQPG5bJOLZZtQ+AY5EJ4q5rW3So X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2016 14:00:10.4525 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR12MB0440 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Suravee Suthikulpanit OVERVIEW ======== This patch set is the first of the two-part patch series to introduce the new AMD Advance Virtual Interrupt Controller (AVIC) support. Basically, SVM AVIC hardware virtualizes local APIC registers of each vCPU via the virtual APIC (vAPIC) backing page. This allows guest access to certain APIC registers without the need to emulate the hardware behavior in the hypervisor. More information about AVIC can be found in the AMD64 Architecture Programmer’s Manual Volume 2 - System Programming. http://support.amd.com/TechDocs/24593.pdf For SVM AVIC, we extend the existing kvm_amd driver to: * Check CPUID to detect AVIC support in the processor * Program new fields in VMCB to enable AVIC * Introduce new AVIC data structures and add code to manage them * Handle two new AVIC #VMEXITs * Add new interrupt intjection code using vAPIC backing page instead of the existing V_IRQ, V_INTR_PRIO, V_INTR_VECTOR, and V_IGN_TPR fileds Currently, this patch series does not enable AVIC by default. Users can enable SVM AVIC by specifying avic=1 during insmod kvm-amd. Later, in part 2, we will introduce the IOMMU AVIC support, which provides speed up for PCI device passthrough use case by allowing the IOMMU hardware to inject interrupt directly into the guest via the vAPIC backing page. PERFORMANCE RESULTS =================== Currently, AVIC is supported in the AMD family 15h models 6Xh (Carrizo) processors. Therefore, it is used to collect the perforamance data shown below. Generaly, SVM AVIC alone (w/o IOMMU AVIC) should provide speedup for IPI interrupt since hypervisor does not require VMEXIT to inject these interrupts. Also, it should speed up the case when hypervisor wants to inject an interrupt into a running guest by setting the corresponded IRR bit in the vAPIC backing page and trigger AVIC_DOORBELL MSR. IPI PERFORMANCE =============== For IPI, I have collected some performance number on 2 and 4 CPU running hackbech with the following detail: hackbench -p -l 100000 Running in process mode with 10 groups using 40 file descriptors each (== 400 tasks) Each sender will pass 100000 messages of 100 bytes | 2 vcpus | 4 vcpus ------------------------------------------------ Vanila | 273.76 | 190.21 AVIC disabled | 260.51 (~5%) | 184.40 (~5%) AVIC | 239.03 (~10%)| 166.37 (~10%) OVERALL PERFORMANCE =================== Enabling AVIC should helps speeding up workloads, which generate large amount of interrupts. However, it requires additional logics to: * Maintain AVIC-specific data structures during vCPU load/unload due to schedule in/out. * Track and manange interrupt pending in vAPIC backing page. The goal is to minimize the overhead of AVIC in most cases, so that we can achieve equivalent or improvement in overall performance when enabling AVIC. This is an on-going investigation and to be discussed. CURRENT UNSUPPORT USE-CASES =========================== - Nested VM - VM Migration GITHUB ====== Latest git tree can be found at: http://github.com/ssuthiku/linux.git avic_part1_rfc Any feedback and comments are very much appreciated. Thank you, Suravee Suravee Suthikulpanit (9): KVM: x86: Misc LAPIC changes to exposes helper functions svm: Introduce new AVIC VMCB registers svm: clean up V_TPR, V_IRQ, V_INTR_PRIO, and V_INTR_MASKING KVM: x86: Detect and Initialize AVIC support svm: Add VMEXIT handlers for AVIC svm: Add interrupt injection via AVIC svm: Do not expose x2APIC when enable AVIC svm: Do not intercept CR8 when enable AVIC svm: Manage vcpu load/unload when enable AVIC arch/x86/include/asm/cpufeature.h | 1 + arch/x86/include/asm/kvm_host.h | 4 + arch/x86/include/asm/msr-index.h | 1 + arch/x86/include/asm/svm.h | 38 +- arch/x86/include/uapi/asm/svm.h | 9 +- arch/x86/kernel/cpu/scattered.c | 1 + arch/x86/kvm/lapic.c | 53 +-- arch/x86/kvm/lapic.h | 5 + arch/x86/kvm/svm.c | 882 +++++++++++++++++++++++++++++++++++++- arch/x86/kvm/x86.c | 4 +- 10 files changed, 940 insertions(+), 58 deletions(-) -- 1.9.1