From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753474AbcBOOgr (ORCPT ); Mon, 15 Feb 2016 09:36:47 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:32635 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753366AbcBOOgo (ORCPT ); Mon, 15 Feb 2016 09:36:44 -0500 X-AuditID: cbfec7f5-f79b16d000005389-c3-56c1e279f95b From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Ralf Baechle , linux-mips@linux-mips.org Subject: [PATCH 2/7] MIPS: module: fix incorrect IS_ERR_VALUE macro usages Date: Mon, 15 Feb 2016 15:35:20 +0100 Message-id: <1455546925-22119-3-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1455546925-22119-1-git-send-email-a.hajda@samsung.com> References: <1455546925-22119-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpkluLIzCtJLcpLzFFi42I5/e/4Vd3KRwfDDPaeMbe4te4cq8XGGetZ LS7vmsNmMWHqJHaLtUfusltc2qPiwOZxdOVaJo++LasYPT5vkgtgjuKySUnNySxLLdK3S+DK mLfvMXvBK56K1ccuszQwXufqYuTkkBAwkfjVsIUJwhaTuHBvPRuILSSwlFHiwnwhCLuJSWJf cwWIzSagKfF3802wGhEBBYnNvc9Yuxi5OJgFzjNKbHz7mxEkISzgJfFg/RIWEJtFQFViyrfP 7F2MHBy8As4Sh2dpQOySkzh5bDIrSJhTwEViwd4CiFXOEvt3b2OawMi7gJFhFaNoamlyQXFS eq6RXnFibnFpXrpecn7uJkZIwHzdwbj0mNUhRgEORiUe3ogzB8KEWBPLiitzDzFKcDArifBa nD4YJsSbklhZlVqUH19UmpNafIhRmoNFSZx35q73IUIC6YklqdmpqQWpRTBZJg5OqQbGiKSV ssvWPd4QMDV/U90Zn2nNt4KOqb368TGb68mEPTJrPxTcO3O+7OwHiyWTFYIKJ+nq+HmdfWpz yW5DUP7p9b+8zKxydH2FvV1+KgXOibQ33CBX6ORQHBQ7d5fRa1Wf7MfL3/xznvhqeQBH4N24 BUqiQpd9vgkubl9l4TXrdOq7pi1TZt9hVWIpzkg01GIuKk4EADxuafgUAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org IS_ERR_VALUE macro should be used only with unsigned long type. Specifically it works incorrectly with longer types. The patch follows conclusion from discussion on LKML [1][2]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2120927 [2]: http://permalink.gmane.org/gmane.linux.kernel/2150581 Signed-off-by: Andrzej Hajda --- arch/mips/kernel/module-rela.c | 2 +- arch/mips/kernel/module.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/mips/kernel/module-rela.c b/arch/mips/kernel/module-rela.c index 2b70723..08100dc 100644 --- a/arch/mips/kernel/module-rela.c +++ b/arch/mips/kernel/module-rela.c @@ -125,7 +125,7 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab, /* This is the symbol it is referring to */ sym = (Elf_Sym *)sechdrs[symindex].sh_addr + ELF_MIPS_R_SYM(rel[i]); - if (IS_ERR_VALUE(sym->st_value)) { + if (sym->st_value >= -MAX_ERRNO) { /* Ignore unresolved weak symbol */ if (ELF_ST_BIND(sym->st_info) == STB_WEAK) continue; diff --git a/arch/mips/kernel/module.c b/arch/mips/kernel/module.c index 1833f51..2ba73bf4 100644 --- a/arch/mips/kernel/module.c +++ b/arch/mips/kernel/module.c @@ -214,7 +214,7 @@ int apply_relocate(Elf_Shdr *sechdrs, const char *strtab, /* This is the symbol it is referring to */ sym = (Elf_Sym *)sechdrs[symindex].sh_addr + ELF_MIPS_R_SYM(rel[i]); - if (IS_ERR_VALUE(sym->st_value)) { + if (sym->st_value >= -MAX_ERRNO) { /* Ignore unresolved weak symbol */ if (ELF_ST_BIND(sym->st_info) == STB_WEAK) continue; -- 1.9.1