From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753510AbcBOOhC (ORCPT ); Mon, 15 Feb 2016 09:37:02 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:29564 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753366AbcBOOgs (ORCPT ); Mon, 15 Feb 2016 09:36:48 -0500 X-AuditID: cbfec7f4-f79026d00000418a-e7-56c1e27bd1bc From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Greg Kroah-Hartman , Jiri Slaby , Alexander Shiyan , linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 5/7] serial: clps711x: fix IS_ERR_VALUE usage Date: Mon, 15 Feb 2016 15:35:23 +0100 Message-id: <1455546925-22119-6-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1455546925-22119-1-git-send-email-a.hajda@samsung.com> References: <1455546925-22119-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHLMWRmVeSWpSXmKPExsVy+t/xq7rVjw6GGXz9zW5xa905VouNM9az WjQvXs9mMWXDByaLTY+vsVpc3jWHzeLM4l52i7VH7rJbTNoh5cDpsX/uGnaPzUvqPabMPcLq 0bdlFaPH+i1XWTw+b5ILYIvisklJzcksSy3St0vgyuj6uIex4CZnRc+nqAbGbo4uRg4OCQET iddt/l2MnECmmMSFe+vZQGwhgaWMEs0//boYuYDsJiaJddO+MYEk2AQ0Jf5uvglWJCKgILG5 9xkrSBGzwBkmieMzz7KAJIQFbCXenH4LVsQioCqx7f0bZhCbV8BZ4tOBL8wQ2+QkTh6bzApy BKeAi8SCvQUQi50l9u/exjSBkXcBI8MqRtHU0uSC4qT0XEO94sTc4tK8dL3k/NxNjJBQ+7KD cfExq0OMAhyMSjy8EWcOhAmxJpYVV+YeYpTgYFYS4bU4fTBMiDclsbIqtSg/vqg0J7X4EKM0 B4uSOO/cXe9DhATSE0tSs1NTC1KLYLJMHJxSDYwR+2NPHNL4eOO9/dXH7IdKlb6Y8Gslim37 09OSedpqsmhL/p1D2Tl7v7850mBy+1o/896lMR/fsSao3Pn72zps96R92xruiD7s65bgnRA0 wVysqoBlnoq+/nPvpS3Ktvdmu9YsuPSA57n5f6UPtpfk5uxKP5b5WNa56eqr8wEBv5kOdAU8 a/ygxFKckWioxVxUnAgAJCE8SzECAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org IS_ERR_VALUE macro should be used only with unsigned long type. For signed types comparison 'ret < 0' should be used. The patch follows conclusion from discussion on LKML [1][2]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2120927 [2]: http://permalink.gmane.org/gmane.linux.kernel/2150581 Signed-off-by: Andrzej Hajda --- drivers/tty/serial/clps711x.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/tty/serial/clps711x.c b/drivers/tty/serial/clps711x.c index b3a4e0c..0096ebe 100644 --- a/drivers/tty/serial/clps711x.c +++ b/drivers/tty/serial/clps711x.c @@ -467,13 +467,15 @@ static int uart_clps711x_probe(struct platform_device *pdev) if (IS_ERR(s->port.membase)) return PTR_ERR(s->port.membase); - s->port.irq = platform_get_irq(pdev, 0); - if (IS_ERR_VALUE(s->port.irq)) - return s->port.irq; + ret = platform_get_irq(pdev, 0); + if (ret < 0) + return ret; + s->port.irq = ret; - s->rx_irq = platform_get_irq(pdev, 1); - if (IS_ERR_VALUE(s->rx_irq)) - return s->rx_irq; + ret = platform_get_irq(pdev, 1); + if (ret < 0) + return ret; + s->rx_irq = ret; if (!np) { char syscon_name[9]; -- 1.9.1