From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753540AbcBOOhs (ORCPT ); Mon, 15 Feb 2016 09:37:48 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:8238 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753468AbcBOOgr (ORCPT ); Mon, 15 Feb 2016 09:36:47 -0500 X-AuditID: cbfec7f4-f79026d00000418a-e9-56c1e27c7f39 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Li Yang , Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH 7/7] usb: gadget: fsl_qe_udc: fix IS_ERR_VALUE usage Date: Mon, 15 Feb 2016 15:35:25 +0100 Message-id: <1455546925-22119-8-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1455546925-22119-1-git-send-email-a.hajda@samsung.com> References: <1455546925-22119-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrALMWRmVeSWpSXmKPExsVy+t/xq7o1jw6GGZw5JGhxa905VouNM9az Whxre8Ju0bx4PZvFrwdCFpd3zWGzWLSsldni9/d/rBZrj9xld+D0+He4n8lj06pONo/9c9ew e5yfsZDRo2/LKkaPz5vkAtiiuGxSUnMyy1KL9O0SuDKufbvBXnCIveL8rl8sDYwb2boYOTgk BEwk3r2W7mLkBDLFJC7cWw8U5uIQEljKKLEYqA7CaWKS2L/gAxtIFZuApsTfzTfBbBEBBYnN vc9YQYqYBfYzSXxr6WYHmSos4CKx57cbSA2LgKpEy/ptzCA2r4CzxLUll9ghtslJnDw2mRWk nBOofMHeApCwEFDJ/t3bmCYw8i5gZFjFKJpamlxQnJSea6hXnJhbXJqXrpecn7uJERJuX3Yw Lj5mdYhRgINRiYc34syBMCHWxLLiytxDjBIczEoivBanD4YJ8aYkVlalFuXHF5XmpBYfYpTm YFES5527632IkEB6YklqdmpqQWoRTJaJg1OqgTF3g6VlRY1x2feYxodiwq8fKwjbVBbsmB4s 3OOg/umW6a+rDyqurvyVei+Mzeha9LqXexZOsynT/Jvhn9r58W3F7BW+M7kXruHgW5vo2L73 +V9JuQC/14f+tPG2BKfP6tqvFC3GO+HZs8BnyX3L3bv83FoKlDqtuLIsFrvtSpG8xfH/6mvZ GiWW4oxEQy3mouJEAPch6BIzAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org IS_ERR_VALUE macro should be used only with unsigned long type. Otherwise it can work incorrectly. The patch follows conclusion from discussion on LKML [1][2]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2120927 [2]: http://permalink.gmane.org/gmane.linux.kernel/2150581 Signed-off-by: Andrzej Hajda --- drivers/usb/gadget/udc/fsl_qe_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/fsl_qe_udc.c b/drivers/usb/gadget/udc/fsl_qe_udc.c index 53c0692..93d28cb 100644 --- a/drivers/usb/gadget/udc/fsl_qe_udc.c +++ b/drivers/usb/gadget/udc/fsl_qe_udc.c @@ -2340,7 +2340,7 @@ static struct qe_udc *qe_udc_config(struct platform_device *ofdev) { struct qe_udc *udc; struct device_node *np = ofdev->dev.of_node; - unsigned int tmp_addr = 0; + unsigned long tmp_addr = 0; struct usb_device_para __iomem *usbpram; unsigned int i; u64 size; -- 1.9.1