From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751779AbcBOQ1I (ORCPT ); Mon, 15 Feb 2016 11:27:08 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:40284 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751187AbcBOQ1E (ORCPT ); Mon, 15 Feb 2016 11:27:04 -0500 X-Sasl-enc: pUK4fYNKuDbXuV2cPhEeqDlRL7fWJ08qD1QMWrNcKyOu 1455553622 Message-ID: <1455553619.3091.9.camel@cvidal.org> Subject: Re: [PATCH v3 5/5] Staging: rtl8188eu/core: make core more readable From: Colin Vidal To: Greg Kroah-Hartman Cc: "open list:STAGING SUBSYSTEM" , open list Date: Mon, 15 Feb 2016 17:26:59 +0100 In-Reply-To: <20160215003949.GA1276@kroah.com> References: <1455300355-14524-1-git-send-email-colin@cvidal.org> <1455300355-14524-2-git-send-email-colin@cvidal.org> <1455300355-14524-3-git-send-email-colin@cvidal.org> <1455300355-14524-4-git-send-email-colin@cvidal.org> <1455300355-14524-5-git-send-email-colin@cvidal.org> <20160215003949.GA1276@kroah.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.4 (3.18.4-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-02-14 at 16:39 -0800, Greg Kroah-Hartman wrote: > On Fri, Feb 12, 2016 at 07:05:53PM +0100, Colin Vidal wrote: > > Signed-off-by: Colin Vidal > > --- > >  drivers/staging/rtl8188eu/core/rtw_iol.c | 10 +++------- > >  1 file changed, 3 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c > > b/drivers/staging/rtl8188eu/core/rtw_iol.c > > index 2e2145c..ba6c492 100644 > > --- a/drivers/staging/rtl8188eu/core/rtw_iol.c > > +++ b/drivers/staging/rtl8188eu/core/rtw_iol.c > > @@ -18,11 +18,7 @@ > >   > >  bool rtw_IOL_applied(struct adapter *adapter) > >  { > > - if (adapter->registrypriv.fw_iol == 1) > > - return true; > > - > > - if ((adapter->registrypriv.fw_iol == 2) && > > -     (!adapter_to_dvobj(adapter)->ishighspeed)) > > - return true; > > - return false; > > + return adapter->registrypriv.fw_iol == 1 || > > + (adapter->registrypriv.fw_iol == 2 && > > +  !adapter_to_dvobj(adapter)->ishighspeed); > >  } > > I'm sorry, but this patch does not do what you said it does, it's > much > harder to read now :( > > Also, I can't take a patch without a changelog text :( > > thanks, > > greg k-h Hi Greg, Thanks for you replie! OK, I thought it was a better idea (as suggests Joe Perches) to group the test in a way to avoid multiples - and maybe confusing - returns. So, I'll remove this one. Sorry about the changelot, I missed it while making patch series, I'll resend it. Thanks, Colin