From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752458AbcBPIjl (ORCPT ); Tue, 16 Feb 2016 03:39:41 -0500 Received: from mail.skyhub.de ([78.46.96.112]:57083 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752604AbcBPIjk (ORCPT ); Tue, 16 Feb 2016 03:39:40 -0500 From: Borislav Petkov To: LKML Cc: alex.williamson@redhat.com, gleb@kernel.org, joro@8bytes.org, kvm@vger.kernel.org, Paolo Bonzini , sherry.hurwitz@amd.com, Suravee Suthikulpanit , wei@redhat.com, x86-ml Subject: [PATCH] x86/msr: Document msr-index.h rule for addition Date: Tue, 16 Feb 2016 09:39:37 +0100 Message-Id: <1455611977-14179-1-git-send-email-bp@alien8.de> X-Mailer: git-send-email 2.3.5 In-Reply-To: <20160216075041.GA27440@gmail.com> References: <20160216075041.GA27440@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Borislav Petkov In order to keep this file's size sensible and not cause too much unnecessary churn, make the rule explicit - similar to pci_ids.h - that only MSRs which are used in multiple compilation units, should get added to it. Signed-off-by: Borislav Petkov Acked-by: Ingo Molnar Cc: alex.williamson@redhat.com Cc: gleb@kernel.org Cc: joro@8bytes.org Cc: kvm@vger.kernel.org CC: Paolo Bonzini Cc: sherry.hurwitz@amd.com Cc: Suravee Suthikulpanit Cc: wei@redhat.com Cc: x86-ml --- arch/x86/include/asm/msr-index.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h index b05402ef3b84..984ab75bf621 100644 --- a/arch/x86/include/asm/msr-index.h +++ b/arch/x86/include/asm/msr-index.h @@ -1,7 +1,12 @@ #ifndef _ASM_X86_MSR_INDEX_H #define _ASM_X86_MSR_INDEX_H -/* CPU model specific register (MSR) numbers */ +/* + * CPU model specific register (MSR) numbers. + * + * Do not add new entries to this file unless the definitions are shared + * between multiple compilation units. + */ /* x86-64 specific MSRs */ #define MSR_EFER 0xc0000080 /* extended feature register */ -- 2.3.5