From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752096AbcBUU7u (ORCPT ); Sun, 21 Feb 2016 15:59:50 -0500 Received: from smtprelay0147.hostedemail.com ([216.40.44.147]:33546 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751373AbcBUU7t (ORCPT ); Sun, 21 Feb 2016 15:59:49 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1261:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3867:3868:3872:3873:3874:4321:5007:6120:6742:7652:10004:10400:10848:11026:11232:11473:11657:11658:11783:11914:12043:12296:12438:12517:12519:12740:13069:13161:13229:13311:13357:13894:14659:21080:30012:30054:30064:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: wren23_38185ee729f0c X-Filterd-Recvd-Size: 2530 Message-ID: <1456088384.31061.2.camel@perches.com> Subject: Re: [RFC PATCH 7/9] iio: imu: inv_mpu6050: Fix alignment with open parenthesis From: Joe Perches To: Jonathan Cameron , Daniel Baluta Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, wsa@the-dreams.de, linux-i2c@vger.kernel.org, lucas.demarchi@intel.com, srinivas.pandruvada@linux.intel.com, ggao@invensense.com, adi.reus@gmail.com, cmo@melexis.com, mwelling@ieee.org Date: Sun, 21 Feb 2016 12:59:44 -0800 In-Reply-To: <56CA2101.8050805@kernel.org> References: <1455810794-3188-1-git-send-email-daniel.baluta@intel.com> <1455810794-3188-8-git-send-email-daniel.baluta@intel.com> <56CA2101.8050805@kernel.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-02-21 at 20:41 +0000, Jonathan Cameron wrote: > On 18/02/16 15:53, Daniel Baluta wrote: > > This makes code consistent around inv_mpu6050 driver and > > fixes the following checkpatch.pl warning: > > CHECK: Alignment should match open parenthesis > > > > Note that there were few cases were it was not possible to > > fix this due to making the line too long, but we can live with that. > > > > Signed-off-by: Daniel Baluta > Applied [] > > diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c [] > > @@ -217,11 +217,10 @@ static int inv_mpu6050_sensor_show(struct inv_mpu6050_state  *st, int reg, > >   return IIO_VAL_INT; > >  } > >   > > -static int inv_mpu6050_read_raw(struct iio_dev *indio_dev, > > -       struct iio_chan_spec const *chan, > > -       int *val, > > -       int *val2, > > -       long mask) { > > +static int > > +inv_mpu6050_read_raw(struct iio_dev *indio_dev, > > +      struct iio_chan_spec const *chan, > > +      int *val, int *val2, long mask) { Ideally, you'd also convert this form to use the open brace on a new line like: static int inv_mpu6050_read_raw(struct iio_dev *indio_dev,      struct iio_chan_spec const *chan,      int *val, int *val2, long mask) {