From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755790AbcBVUzm (ORCPT ); Mon, 22 Feb 2016 15:55:42 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:51560 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755642AbcBVUyw (ORCPT ); Mon, 22 Feb 2016 15:54:52 -0500 From: Stephen Boyd To: Michael Turquette , Stephen Boyd Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Hans de Goede , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , linux-fbdev@vger.kernel.org Subject: [PATCH 9/9] simplefb: Remove impossible check for of_clk_get_parent_count() < 0 Date: Mon, 22 Feb 2016 12:54:47 -0800 Message-Id: <1456174487-28397-10-git-send-email-sboyd@codeaurora.org> X-Mailer: git-send-email 2.6.3.369.g91ad409 In-Reply-To: <1456174487-28397-1-git-send-email-sboyd@codeaurora.org> References: <1456174487-28397-1-git-send-email-sboyd@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The check for < 0 is impossible now that of_clk_get_parent_count() returns an unsigned int. Simplify the code and update the types. Cc: Hans de Goede Cc: Jean-Christophe Plagniol-Villard Cc: Tomi Valkeinen Cc: Signed-off-by: Stephen Boyd --- Please ack so this can go through clk tree along with patch 1. drivers/video/fbdev/simplefb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c index 48ccf6db62a2..e9cf19977285 100644 --- a/drivers/video/fbdev/simplefb.c +++ b/drivers/video/fbdev/simplefb.c @@ -174,7 +174,7 @@ static int simplefb_parse_pd(struct platform_device *pdev, struct simplefb_par { u32 palette[PSEUDO_PALETTE_SIZE]; #if defined CONFIG_OF && defined CONFIG_COMMON_CLK - int clk_count; + unsigned int clk_count; struct clk **clks; #endif #if defined CONFIG_OF && defined CONFIG_REGULATOR @@ -213,7 +213,7 @@ static int simplefb_clocks_init(struct simplefb_par *par, return 0; par->clk_count = of_clk_get_parent_count(np); - if (par->clk_count <= 0) + if (!par->clk_count) return 0; par->clks = kcalloc(par->clk_count, sizeof(struct clk *), GFP_KERNEL); -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project