From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753007AbcBWON4 (ORCPT ); Tue, 23 Feb 2016 09:13:56 -0500 Received: from mail-bn1on0065.outbound.protection.outlook.com ([157.56.110.65]:6757 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752318AbcBWONx (ORCPT ); Tue, 23 Feb 2016 09:13:53 -0500 Authentication-Results: 8bytes.org; dkim=none (message not signed) header.d=none;8bytes.org; dmarc=none action=none header.from=amd.com; From: Suravee Suthikulpanit To: , , , , CC: , , , , , "Suravee Suthikulpanit" , Suravee Suthikulpanit Subject: [PATCH V5 01/10] perf/amd/iommu: Misc fix up perf_iommu_read Date: Tue, 23 Feb 2016 08:12:35 -0600 Message-ID: <1456236764-1569-2-git-send-email-Suravee.Suthikulpanit@amd.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1456236764-1569-1-git-send-email-Suravee.Suthikulpanit@amd.com> References: <1456236764-1569-1-git-send-email-Suravee.Suthikulpanit@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [124.121.8.20] X-ClientProxiedBy: HKNPR06CA0045.apcprd06.prod.outlook.com (10.141.16.35) To BLUPR12MB0436.namprd12.prod.outlook.com (25.162.92.141) X-MS-Office365-Filtering-Correlation-Id: 2e613f52-bec6-427a-21de-08d33c5b8e1d X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0436;2:w8J2wbbjDvt3UlFVqJazRQis47qaQgsHEFM61c/d6n4j4TUWDrUGwYsdpBeBVQhLgBvB9HzZbzVSz5Y5UN1Xd/efSMHCB2SVeY27n3yEoFCvQGvRFHpK62UiAIV8s61jddpTFNZo3C72o/9DKZbbrY+eEyk2ZJDH/lLC5f+IGYY5JVhp33yAUKPEWPu2Eb5c;3:wNSlBzCsuAiaTeKa9P4J4OpO0YdAX2HyvHtI07/yNb9N+t8Ry0MGDa8eAHLS64d3mZLrY0n556rUjybXgU4aMRbKPukv8Mzpcaxw9uKIfeXNk2htfhB5aC6KYIUJgKMa;25:6d7rUH7W5d27wO7wb7n0KVZP6+CvHSK0utC2k1R1FbjYnICdomisifonXWH60b5tO+95Ec+dzCXkdC8QMDAfpUo8E3ZoyJLcQIJXdY7ak285BZOzO8QQ6M8npV+LYCq73XP7OHEY6kF7NjdS7aFVtE4xYgqd+7oo8ObmchXpOG19f11/zbpi+XQsm+miYb5D7xerHZAsPLbZ9qpQQa6Mw+ZMd99ScsZLrqZ+/shEubmHBLaq52MffaEO9rVz/RAt3+0YzEqrN9R1fGlvNUhdJ2yPfJSM1Yb568KIFZK5wZImO1evROvcR4Uf3yCPn0Wiv7D/HovcVKXgKFVumy/q1secZZv1HkFA11c8v056PiQ= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0436; X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0436;20:WZhVsrRZA0AtozgGNlj6E1PXiI64fnbGds1/mHjjqjDm3mqTJwzCoypklFBZqfzWzfp0Wea9baIxQBPxvczZ0uOXRdHsH6DC5AY/OjyXR1QMZCoXYVDFwN+kvG6NcLQx13rOPzDP5OUUvOkxv8E9mVlEsQ/JPUuy1sICMSH9LZ6nFZ1bnrTHhRX9ErMkgpD6sGtqfUTBx2+T4950NZtVgefITEvz5yV3dxfwKgwWsIQBwhYni6GFHc9wDC8wGFfsu18phhCU7RuhB4aWQkJV8n8kq1SYx9J+UsCFKpnNmG8YX+KGXR1Ckkf0+bzFYy/Kvp+tK+iu5a3Dj8jRdmqysoT47YEAR+cwDPPvf3i01hvK/Pc1cmPqFIzhIllUN+9w9RIrSQVSnvKafNHM74xINPqcXH8tG44BrSTmrQNaaQEW7RS6WuXEeQq/H6jOHIEAM+vMy/wvDXJ+VYJ+S7J9OGfW7hlVAu2X4HEOulU8dtQBrKp88N4kNIGFn2fgXS9s;4:xf9d1z+dL0/ZVL+XfE+6DdzlqTaiBhZaqpX0QnDK8nypw23dhEkpJXB0f/gErKhI3zTaiaUzagbJe9m4J3dx4aSHMnYFyvgsyB2S7aJBiPiwS2VStT9aJcOrH0haN/bY9bgka43Qt6TNbPs3i1BUNiWHhEy9f1Y1DT99GDCEZAP50IKCfzQaNcgpi5vEAuHYgTFZZmQigBTI9+JbCnDe117/P87xjNWWNWW1+h5gswXdLVAU76UemYQw5/5I1DGkY5zkzGiK2LQAzGsfJKvygN2+W2AbCJGWrLnwKoUzy8bh40RoYi9tNrEkyCt1w21yehgzaxHsEBMbt+Y+ZZR/2Jf6koq6BCFlC2hgzpXAs4x8fTuMNNpx1adBfb2VWHg9rHNkUMtloZJWOIqvlGTjxOFa6lpwnOsPKvWmvIQ1uYU= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:BLUPR12MB0436;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0436; X-Forefront-PRVS: 08617F610C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6069001)(5004730100002)(48376002)(77096005)(4326007)(2950100001)(2906002)(3846002)(6116002)(42186005)(5008740100001)(19580405001)(1096002)(19580395003)(86362001)(575784001)(40100003)(50466002)(586003)(122386002)(36756003)(76176999)(5001960100002)(47776003)(66066001)(50986999)(5001770100001)(189998001)(229853001)(50226001)(87976001)(92566002)(2201001);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR12MB0436;H:localhost.localdomain;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BLUPR12MB0436;23:/ieRiL9EdvWIRH/oyc6T4x2wlFD2+j153JOL2sVjR?= =?us-ascii?Q?nwTsYc7AqE/sslzTKFQGSBW3/FVA3gJW7yBqs/H+7XjxzmHACozGIBPI8i0r?= =?us-ascii?Q?5v6UZIMxuZ6ftvzsGWJm2AdLb19vSX6sDwZnmVJpCXJ4OHEcIUmUuBipgTzE?= =?us-ascii?Q?1JWOLLXsOmX4T2JpnWlcENap5qmNC9/uBkjBVcj9+Kt5Zbxf/Be8tHWWye8t?= =?us-ascii?Q?p4Pd4lSzw/XS1bdKSSPUDNChy9Nl4KbYZrmnFd1lMvqVhIba5s+nKkY/z8OR?= =?us-ascii?Q?EScXsMIrQ405t8gBqpoduQrI2wjJP/zHGR+hSBazhCaxHmwGwl7v0w1+SQf/?= =?us-ascii?Q?qnd66f/KS15x0e+K1XJeaPsSn/TtjkWgjidnAHlUqDv25JmFTLsLxprZgUuv?= =?us-ascii?Q?hcobApnhq22JxkHi0z2eEfmAKBGrySWIiKCQHXthfq1nh7OwLL64MzA/dOc8?= =?us-ascii?Q?S9LroNT22KKb5QWZO5GOi4KxpocPSnNpYrv3LYS98Gif2vWYgUsycmK1FguK?= =?us-ascii?Q?FDn+r4+glG9vsY6tcmnItrVtRXgc2G7Dby9Fe7J8Hj+4rUZG7ZtPHZUvDu4W?= =?us-ascii?Q?7zL5070iviyeQx/aoTFWpucAbUMB7RvEL91jv/umpnnp2x+RTKlcW+QkTAAE?= =?us-ascii?Q?QS+4RxpRv/wPXQtDptgteoEnZam9BoOi/emNeXnFgezlebPi2/1fQZnmekYv?= =?us-ascii?Q?1wh7Uc/LRXtDPs2JDvzkpWUew+G56Ffps8F2xgWaR3a694Z4vCmRV9heX9cJ?= =?us-ascii?Q?n9W7iU3TOGuG1SAQWIeM8ikFuapVZfQoAItRZMJ588BKaskZKjiTQyTt0Fmn?= =?us-ascii?Q?J9lk72k0aLQ88BZWGAMXedX89vzcJBNFFfWJsMgOODeyr1lFQeiminP09LlK?= =?us-ascii?Q?pCFjaqBuK1D+EZWse2y7mUy5NuraaNlNcfxnsVv7daygjlpn/bxsSZ2MiwS5?= =?us-ascii?Q?5DTvUEY5OZ1gDlxd5+rWzEur5ry70FvfNeif7uhDQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0436;5:2Nm7Djg/duL/0CzPr0MklQcGX9oEclDZidH5N0hunEr85t9qixaEsLRWqun0JQR227kt1YvB85Q+DWwUCQCcBlrEz/GBJjwF/annN4td3khC901/+oIMRdckMPhK3sD6iXHylaIpqZIPPxTCapbJJA==;24:MgXmyoRkckX/h/5nKCsr5cCjv6z/+zr0OWugYQohjhPMFT/0OXC1aDtxUuOL5OlLbiz3aTcmrKt3/1Ue2/EYnweW7tsVBeUEMBal4q2rjzI=;20:W4mefvjwydemyckcB9yWJ6OBAOuOLLtns3KxzsUMzSvkp2TD3P2KHKQJC+MRtp3n28sFuwCskab0ARBde6WojQk8OKC/gPyxqVy0JD4+R4Lsy5lmxoTLNnJhi2OU2Dijtw6sq3830ehZf4ypaA8VGUhHH8gvtIRWDhiaLALf2SjKERjf74eV/pvtjQmwnQDfQjdl+Mg82GrztepBM6O/zsrsQzggD4JzN4NexMqz3PUglKItrstG8WItadN8LReW X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2016 14:13:42.0833 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR12MB0436 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch contains the follow minor fixup: * Fixed overflow handling since u64 delta would lose the MSB sign bit. * Remove unnecessary local64_set(). * Coding style and make use of GENMASK_ULL macro. Cc: Peter Zijlstra Cc: Borislav Petkov Signed-off-by: Suravee Suthikulpanit --- arch/x86/events/amd/iommu.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/arch/x86/events/amd/iommu.c b/arch/x86/events/amd/iommu.c index 629bc70..9da0d16 100644 --- a/arch/x86/events/amd/iommu.c +++ b/arch/x86/events/amd/iommu.c @@ -314,9 +314,8 @@ static void perf_iommu_start(struct perf_event *event, int flags) static void perf_iommu_read(struct perf_event *event) { - u64 count = 0ULL; - u64 prev_raw_count = 0ULL; - u64 delta = 0ULL; + u64 cnt, prev; + s64 delta; struct hw_perf_event *hwc = &event->hw; pr_debug("perf: amd_iommu:perf_iommu_read\n"); @@ -325,18 +324,20 @@ static void perf_iommu_read(struct perf_event *event) IOMMU_PC_COUNTER_REG, &count, false); /* IOMMU pc counter register is only 48 bits */ - count &= 0xFFFFFFFFFFFFULL; + cnt &= GENMASK_ULL(48, 0); - prev_raw_count = local64_read(&hwc->prev_count); - if (local64_cmpxchg(&hwc->prev_count, prev_raw_count, - count) != prev_raw_count) - return; + prev = local64_read(&hwc->prev_count); - /* Handling 48-bit counter overflowing */ - delta = (count << COUNTER_SHIFT) - (prev_raw_count << COUNTER_SHIFT); + /* + * Since we do not enable counter overflow interrupts, + * we do not have to worry about prev_count changing on us. + */ + local64_set(&hwc->prev_count, cnt); + + /* Handle 48-bit counter overflow */ + delta = (cnt << COUNTER_SHIFT) - (prev << COUNTER_SHIFT); delta >>= COUNTER_SHIFT; local64_add(delta, &event->count); - } static void perf_iommu_stop(struct perf_event *event, int flags) -- 1.9.1