From: Scott Wood <oss@buserror.net>
To: Qiang Zhao <qiang.zhao@nxp.com>, Rob Herring <robh@kernel.org>
Cc: Yang-Leo Li <leoyang.li@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings.
Date: Wed, 24 Feb 2016 23:56:44 -0600 [thread overview]
Message-ID: <1456379804.5360.43.camel@buserror.net> (raw)
In-Reply-To: <AM3PR04MB118518B07AE928823BE73B8491A60@AM3PR04MB1185.eurprd04.prod.outlook.com>
On Thu, 2016-02-25 at 05:55 +0000, Qiang Zhao wrote:
> On Thu, 2016-02-25 at 11:12 AM, Scott Wood wrote:
> > -----Original Message-----
> > From: Scott Wood [mailto:oss@buserror.net]
> > Sent: Thursday, February 25, 2016 11:12 AM
> > To: Qiang Zhao <qiang.zhao@nxp.com>; Rob Herring <robh@kernel.org>
> > Cc: Yang-Leo Li <leoyang.li@nxp.com>; linux-kernel@vger.kernel.org;
> > devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device
> > tree
> > bindings.
> >
> > On Thu, 2016-02-25 at 03:10 +0000, Qiang Zhao wrote:
> > > On Wed, 2016-02-24 at 04:20 AM, Scott Wood wrote:
> > > > -----Original Message-----
> > > > From: Scott Wood [mailto:oss@buserror.net]
> > > > Sent: Wednesday, February 24, 2016 4:20 AM
> > > > To: Rob Herring <robh@kernel.org>; Qiang Zhao <qiang.zhao@nxp.com>
> > > > Cc: Yang-Leo Li <leoyang.li@nxp.com>; linux-kernel@vger.kernel.org;
> > > > devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > > > Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to
> > > > device tree bindings.
> > > >
> > > > On Tue, 2016-02-23 at 14:15 -0600, Rob Herring wrote:
> > > > > On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote:
> > > > > > Add IC, SI and SIRAM document of QE to
> > > > > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > > >
> > > > > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > > > > > ---
> > > > > > Changes for v2
> > > > > > - Add interrupt-controller in Required properties
> > > > > > - delete address-cells and size-cells for qe-si and qe-siram
> > > > > >
> > > > > > .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50
> > > > > > ++++++++++++++++++++++
> > > > > > 1 file changed, 50 insertions(+)
> > > > > >
> > > > > > diff --git
> > > > > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > > > index 4f89302..84052a7 100644
> > > > > > ---
> > > > > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.tx
> > > > > > +++ t
> > > > > > @@ -69,6 +69,56 @@ Example:
> > > > > > };
> > > > > > };
> > > > > >
> > > > > > +* Interrupt Controller (IC)
> > > > > > +
> > > > > > +Required properties:
> > > > > > +- compatible : should be "fsl,qe-ic".
> > > > >
> > > > > > +- compatible : should be "fsl,qe-si".
> > > > >
> > > > > > +- compatible : should be "fsl,qe-siram".
> > > > >
> > > > > These compatible strings are all a bit generic and should have SoC
> > > > > specific compatible strings.
> > > >
> > > > I don't know about si/siram, but "fsl,qe-ic" has been around since
> > > > 2008, so it should be documented even if a more specific compatible
> > > > is also added.
> > >
> > > Agree, and si/siram are also has been around since 2008.
> >
> > Where? I couldn't find them when grepping.
>
> Sorry, I make a mistake, they have not been in upstream.
>
> >
> > > In addition, I don’t think it is needed to add specific compatible,
> > > because they are the same in qe-supported soc.
> >
> > How do we know that they are 100% the same?
>
> You mean it will be changed in later version?
That's always a possibility, but even on current chips, what bit of
documentation are you referring to that confirms it's the exact same logic?
-Scott
prev parent reply other threads:[~2016-02-25 5:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 1:06 [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Zhao Qiang
2016-02-18 1:06 ` [PATCH v2 2/7] QE: Add ucc hdlc document to bindings Zhao Qiang
2016-02-23 20:21 ` Rob Herring
2016-02-25 4:37 ` Qiang Zhao
2016-02-18 1:06 ` [PATCH v2 3/7] QE: Add uqe_serial " Zhao Qiang
2016-02-23 20:23 ` Rob Herring
2016-02-23 20:27 ` Scott Wood
2016-02-25 4:44 ` Qiang Zhao
2016-02-18 1:06 ` [PATCH v2 4/7] bindings: move cpm_qe binding from powerpc/fsl to soc/fsl Zhao Qiang
2016-02-23 20:24 ` Rob Herring
2016-02-18 1:06 ` [PATCH v2 5/7] T104xD4RDB: Add qe node to t104xd4rdb Zhao Qiang
2016-02-18 1:06 ` [PATCH v2 6/7] T104xRDB: Add qe node to t104xrdb Zhao Qiang
2016-02-18 1:06 ` [PATCH v2 7/7] T104xQDS: Add qe node to t104xqds Zhao Qiang
2016-02-23 20:15 ` [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Rob Herring
2016-02-23 20:20 ` Scott Wood
2016-02-25 3:10 ` Qiang Zhao
2016-02-25 3:11 ` Scott Wood
2016-02-25 5:55 ` Qiang Zhao
2016-02-25 5:56 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456379804.5360.43.camel@buserror.net \
--to=oss@buserror.net \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=qiang.zhao@nxp.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).