From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753474AbcCJQYh (ORCPT <rfc822;w@1wt.eu>);
	Thu, 10 Mar 2016 11:24:37 -0500
Received: from mga14.intel.com ([192.55.52.115]:41930 "EHLO mga14.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752806AbcCJQYa (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 10 Mar 2016 11:24:30 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,316,1455004800"; 
   d="scan'208";a="761730061"
From: "Jiang, Dave" <dave.jiang@intel.com>
To: "Allen.Hubbe@emc.com" <Allen.Hubbe@emc.com>,
        "sudipm.mukherjee@gmail.com" <sudipm.mukherjee@gmail.com>,
        "jdmason@kudzu.us" <jdmason@kudzu.us>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-ntb@googlegroups.com" <linux-ntb@googlegroups.com>
Subject: Re: [PATCH] ntb: fix possible NULL dereference
Thread-Topic: [PATCH] ntb: fix possible NULL dereference
Thread-Index: AQHResdfwDZmlJgzuE+Khr4f9o4IhZ9TYyWA
Date: Thu, 10 Mar 2016 16:24:28 +0000
Message-ID: <1457627059.3577.34.camel@intel.com>
References: <1457612471-26128-1-git-send-email-sudipm.mukherjee@gmail.com>
In-Reply-To: <1457612471-26128-1-git-send-email-sudipm.mukherjee@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [143.182.137.38]
Content-Type: text/plain; charset="utf-8"
Content-ID: <F59984587ED6824C809878F1A754E800@intel.com>
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u2AGOga8009952

On Thu, 2016-03-10 at 17:51 +0530, Sudip Mukherjee wrote:
> kmalloc can fail and we should check for NULL before using the
> pointer
> returned by kmalloc.
> 
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Acked-by: Dave Jiang <dave.jiang@intel.com>

Thanks!

> ---
>  drivers/ntb/test/ntb_perf.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/ntb/test/ntb_perf.c
> b/drivers/ntb/test/ntb_perf.c
> index c8a37ba..b21e647 100644
> --- a/drivers/ntb/test/ntb_perf.c
> +++ b/drivers/ntb/test/ntb_perf.c
> @@ -541,6 +541,8 @@ static ssize_t debugfs_run_read(struct file
> *filp, char __user *ubuf,
>  		return 0;
>  
>  	buf = kmalloc(64, GFP_KERNEL);
> +	if (!buf)
> +		return -ENOMEM;
>  	out_offset = snprintf(buf, 64, "%d\n", perf->run);
>  	ret = simple_read_from_buffer(ubuf, count, offp, buf,
> out_offset);
>  	kfree(buf);