From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754832AbcCJSCB (ORCPT ); Thu, 10 Mar 2016 13:02:01 -0500 Received: from lists.s-osg.org ([54.187.51.154]:44773 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754793AbcCJSBt (ORCPT ); Thu, 10 Mar 2016 13:01:49 -0500 From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Mark Brown , linux-spi@vger.kernel.org, Javier Martinez Canillas Subject: [PATCH 1/2] spi: Fix htmldocs build error due struct spi_replaced_transfers Date: Thu, 10 Mar 2016 15:01:13 -0300 Message-Id: <1457632874-11250-2-git-send-email-javier@osg.samsung.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1457632874-11250-1-git-send-email-javier@osg.samsung.com> References: <1457632874-11250-1-git-send-email-javier@osg.samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The kernel-doc has to be just before the structure definition but the one for struct spi_replaced_transfers was before a structure declaration and that confuses kernel-doc which complains with the following build error: .//include/linux/spi/spi.h:933: error: Cannot parse struct or union! Signed-off-by: Javier Martinez Canillas --- include/linux/spi/spi.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h index 520a23d46df6..857a9a1d82b5 100644 --- a/include/linux/spi/spi.h +++ b/include/linux/spi/spi.h @@ -911,6 +911,10 @@ spi_max_transfer_size(struct spi_device *spi) /* SPI transfer replacement methods which make use of spi_res */ +struct spi_replaced_transfers; +typedef void (*spi_replaced_release_t)(struct spi_master *master, + struct spi_message *msg, + struct spi_replaced_transfers *res); /** * struct spi_replaced_transfers - structure describing the spi_transfer * replacements that have occurred @@ -930,10 +934,6 @@ spi_max_transfer_size(struct spi_device *spi) * if some extra allocation is requested, so alignment will be the same * as for spi_transfers */ -struct spi_replaced_transfers; -typedef void (*spi_replaced_release_t)(struct spi_master *master, - struct spi_message *msg, - struct spi_replaced_transfers *res); struct spi_replaced_transfers { spi_replaced_release_t release; void *extradata; -- 2.5.0