From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753350AbcCJTTf (ORCPT <rfc822;w@1wt.eu>);
	Thu, 10 Mar 2016 14:19:35 -0500
Received: from g9t5009.houston.hp.com ([15.240.92.67]:42007 "EHLO
	g9t5009.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752630AbcCJTT1 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 10 Mar 2016 14:19:27 -0500
Message-ID: <1457640722.15454.557.camel@hpe.com>
Subject: Re: runtime regression with "x86/mm/pat: Emulate PAT when it is
 disabled"
From: Toshi Kani <toshi.kani@hpe.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>,
        Borislav Petkov <bp@suse.de>
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>,
        Toshi Kani <toshi.kani@hp.com>,
        Bruce Ashfield <bruce.ashfield@windriver.com>,
        "Hart, Darren" <darren.hart@intel.com>,
        "saul.wold" <saul.wold@intel.com>, linux-kernel@vger.kernel.org
Date: Thu, 10 Mar 2016 13:12:02 -0700
In-Reply-To: <20160310190429.GI23251@windriver.com>
References: <20160307003501.GB26051@windriver.com>
	 <1457366596.15454.281.camel@hpe.com> <20160307210852.GC26051@windriver.com>
	 <1457393912.15454.419.camel@hpe.com> <20160307235328.GD26051@windriver.com>
	 <1457398578.15454.421.camel@hpe.com> <1457400913.15454.435.camel@hpe.com>
	 <20160310144250.GG23251@windriver.com> <1457628591.15454.542.camel@hpe.com>
	 <20160310172029.GA2194@pd.tnic> <20160310190429.GI23251@windriver.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.18.4 (3.18.4-1.fc23) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2016-03-10 at 14:04 -0500, Paul Gortmaker wrote:
> [Re: runtime regression with "x86/mm/pat: Emulate PAT when it is
> disabled"] On 10/03/2016 (Thu 18:20) Borislav Petkov wrote:
> 
> > On Thu, Mar 10, 2016 at 09:49:51AM -0700, Toshi Kani wrote:
> > > This confirms the issue - QEMU's virtual Intel CPU does not support
> > > MTRR. 
> > > 
> > > When MTRR is disabled, the kernel does not call pat_init().
> > >  pat_enabled() is still set to true when CONFIG_X86_PAT is set.
> > >  CONFIG_X86_PAT depends on CONFIG_MTRR, and assumes that MTRR is
> > > enabled. 
> > 
> > Aha, so "qemu32" model doesn't support MTRRs but "kvm32" does, for
> > example. And so do the majority of the other CPU types.
> 
> So, I guess that is a qemu bug?  If there is no real silicon out there
> that has no MTRR but does claim PAT, then qemu32 is a flawed CPU type?

It turns out that your qemu's virtual CPU does not support PAT, either. :-) 
 So, it is consistent on this regard.  I will send patches to address this
issue.

Thanks,
-Toshi