From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755082AbcCKGvl (ORCPT ); Fri, 11 Mar 2016 01:51:41 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:43120 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753198AbcCKGvd (ORCPT ); Fri, 11 Mar 2016 01:51:33 -0500 X-AuditID: cbfec7f5-f79b16d000005389-47-56e26af2b186 From: Andrzej Hajda To: Tom Herbert Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] kcm: fix variable type Date: Fri, 11 Mar 2016 07:51:15 +0100 Message-id: <1457679075-22094-1-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCJMWRmVeSWpSXmKPExsVy+t/xK7qfsh6FGbx7yW9xa905VouNM9az Wsw538JicXnXHDaLtUfuslscWyBmcfnSI2YHdo8tK28yefTOncbq0bdlFaPH501yASxRXDYp qTmZZalF+nYJXBn7X25lK+hnq7j67ChjA2MraxcjB4eEgIlE5+bKLkZOIFNM4sK99WxdjFwc QgJLGSUezj7MDuE0MUmcn3OXHaSKTUBT4u/mm2wgtoiAqsSDCddZQGxmgY+MEnMPy4AMFRZQ l9j0NAskzAJUMmHzZiYQm1fAWeLOpaNMEMvkJE4em8w6gZF7ASPDKkbR1NLkguKk9FwjveLE 3OLSvHS95PzcTYyQsPi6g3HpMatDjAIcjEo8vB+uPQwTYk0sK67MPcQowcGsJMJbHfcoTIg3 JbGyKrUoP76oNCe1+BCjNAeLkjjvzF3vQ4QE0hNLUrNTUwtSi2CyTBycUg2MWSxsa3ZVhIvX 8xxwM89X3l2aNqnjGN+9BHaNjWyP3j1fu+9n9Ffzg2fsnX87vzjw+MuSz1uuPxOeb9C1Mi/Y 3elve+iUwAUJ7XuudNavqr8wZa7u8RLXxnb+Odmdd37Muyv37HkhU5Dg+/pgOY631QtlGSwn /GspmZDify5M6uL84MtvysLXKbEUZyQaajEXFScCAOqKB5wHAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Function skb_splice_bits can return negative values, its result should be assigned to signed variable to allow correct error checking. The problem has been detected using patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci. Signed-off-by: Andrzej Hajda --- net/kcm/kcmsock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/kcm/kcmsock.c b/net/kcm/kcmsock.c index 40662d73..0b68ba7 100644 --- a/net/kcm/kcmsock.c +++ b/net/kcm/kcmsock.c @@ -1483,7 +1483,7 @@ static ssize_t kcm_splice_read(struct socket *sock, loff_t *ppos, long timeo; struct kcm_rx_msg *rxm; int err = 0; - size_t copied; + ssize_t copied; struct sk_buff *skb; /* Only support splice for SOCKSEQPACKET */ -- 1.9.1