From: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
Fenghua Yu <fenghua.yu@intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Oleg Nesterov <oleg@redhat.com>,
"Yu, Yu-cheng" <yu-cheng.yu@intel.com>
Subject: Re: Got FPU related warning on Intel Quark during boot
Date: Fri, 11 Mar 2016 10:50:38 +0000 [thread overview]
Message-ID: <1457693438.2007.8.camel@nexus-software.ie> (raw)
In-Reply-To: <CALCETrUNao+o5CR=xE16Fgbj5HEdyxGogHqVYBVUXzr42qT-eA@mail.gmail.com>
On Thu, 2016-03-10 at 17:31 -0800, Andy Lutomirski wrote:
> On Thu, Mar 10, 2016 at 7:45 AM, Bryan O'Donoghue
> <pure.logic@nexus-software.ie> wrote:
> > On Thu, 2016-03-10 at 17:22 +0200, Andy Shevchenko wrote:
> > > On Thu, Mar 10, 2016 at 4:59 PM, Borislav Petkov <bp@alien8.de>
> > > wrote:
> > > > On Thu, Mar 10, 2016 at 03:31:43PM +0200, Andy Shevchenko
> > > > wrote:
> > > > > Looks like it lacks that one.
> > > > >
> > > > > # grep -i fxsr /proc/cpuinfo; echo $?
> > > > > 1
> > > >
> > > > Ok, so looking at where the warning comes from:
> > > >
> > > > [ 14.714533] WARNING: CPU: 0 PID: 823 at
> > > > arch/x86/include/asm/fpu/internal.h:163 fpu__clear+0x8c/0x160
> > > >
> > > > static inline void copy_kernel_to_fxregs(struct fxregs_state
> > > > *fx)
> > > > {
> > > > int err;
> > > >
> > > > if (config_enabled(CONFIG_X86_32)) {
> > > > err = check_insn(fxrstor %[fx], "=m" (*fx),
> > > > [fx]
> > > > "m" (*fx));
> > > > ^^^^^^^^^^^^^^^^^
> > > > } else {
> > > >
> > > > ...
> > > >
> > > > /* Copying from a kernel buffer to FPU registers should
> > > > never fail: */
> > > > WARN_ON_FPU(err);
> > > >
> > > >
> > > > and the stacktrace is pretty clear:
> > > >
> > > > flush_thread
> > > > > -> fpu__clear(&tsk->thread.fpu);
> > > > |-> we are eager by default here:
> > > >
> > > > if (!use_eager_fpu() ||
> > > > !static_cpu_has(X86_FEATURE_FPU)) {
> > > > /* FPU state will be reallocated lazily at the
> > > > first use. */
> > > > fpu__drop(fpu);
> > > > } else {
> > > >
> > > > --> we're in that branch.
> > > >
> > > > copy_init_fpstate_to_fpregs();
> > > > |-> copy_kernel_to_fxregs()
> > > >
> > > >
> > > > I think we should use FRSTOR on quark, i.e.,
> > > > copy_kernel_to_fregs().
> > > >
> > > > Does this untested wild guess even work?
> > > >
> > > > ---
> > > > diff --git a/arch/x86/kernel/fpu/core.c
> > > > b/arch/x86/kernel/fpu/core.c
> > > > index dea8e76d60c6..bbafe5e8a1a6 100644
> > > > --- a/arch/x86/kernel/fpu/core.c
> > > > +++ b/arch/x86/kernel/fpu/core.c
> > > > @@ -474,8 +474,11 @@ static inline void
> > > > copy_init_fpstate_to_fpregs(void)
> > > > {
> > > > if (use_xsave())
> > > > copy_kernel_to_xregs(&init_fpstate.xsave, -1);
> > > > - else
> > > > + else if (static_cpu_has(X86_FEATURE_FXSR))
> > > > copy_kernel_to_fxregs(&init_fpstate.fxsave);
> > > > + else
> > > > + copy_kernel_to_fregs(&init_fpstate.fsave);
> > > > +
> > >
> > > Obviously redundant line, otherwise it indeed works
> > >
> > > Tested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > >
> > > > }
> > > >
> > > > /*
> > >
> > >
> > >
> >
> > It works but user-space FPU is broken; something's wrong with the
> > initial state of the FPU regs - it looks as though they aren't
> > being
> > properly initialized and FPU context in the signal handler is wrong
> > too.
> >
> > Linux 3.8.7:
> > /root@galileo:~# ./fpu
> > f is 10.000000 g is 10.100000
> > Double value is 0.000000
> > Double value is 0.100000
> > Double value is 0.200000
> > ^Chandler value of variable is 0.300000
> > Double value is 0.300000
> > Double value is 0.400000
> >
> > Linux-next + Boris' fix:
> > root@galileo:~# ./fpu
> > f is -nan g is -nan
> > Double value is 0.000000
> > Double value is 0.100000
> > Double value is 0.200000^C
> > handler value of variable is -nan
> > Double value is 0.300000
> > Double value is 0.400000^Z[1]+ Stopped
> >
>
> Just to check: are you running the exact same compiled binary on both
> kernels? Because your test case invokes undefined behavior, and I'm
> a
> bit surprised you get anything sensible from it. That being said,
> the
> f = -nan part is worrisome.
>
> --Andy
It's the same binary yes.
next prev parent reply other threads:[~2016-03-11 10:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 10:46 Got FPU related warning on Intel Quark during boot Andy Shevchenko
2016-03-10 11:19 ` Ingo Molnar
2016-03-10 12:48 ` Andy Shevchenko
2016-03-10 12:56 ` Borislav Petkov
2016-03-10 13:31 ` Andy Shevchenko
2016-03-10 14:59 ` Borislav Petkov
2016-03-10 15:22 ` Andy Shevchenko
2016-03-10 15:45 ` Bryan O'Donoghue
2016-03-10 16:49 ` Borislav Petkov
2016-03-10 17:15 ` Bryan O'Donoghue
2016-03-10 19:06 ` Borislav Petkov
2016-03-11 1:31 ` Andy Lutomirski
2016-03-11 10:50 ` Bryan O'Donoghue [this message]
2016-03-11 1:39 ` Andy Lutomirski
2016-03-11 9:08 ` Ingo Molnar
2016-03-11 9:48 ` Borislav Petkov
2016-03-11 11:02 ` Bryan O'Donoghue
2016-03-11 11:26 ` Borislav Petkov
2016-03-11 11:32 ` [PATCH] x86/FPU: Fix FPU handling on legacy FPU machines Borislav Petkov
2016-03-11 18:32 ` Linus Torvalds
2016-03-11 22:03 ` Borislav Petkov
2016-03-11 22:07 ` Dave Hansen
2016-03-11 22:20 ` Borislav Petkov
2016-03-12 17:21 ` Andy Lutomirski
2016-03-12 17:47 ` Borislav Petkov
2016-03-12 12:04 ` Bryan O'Donoghue
2016-03-12 12:27 ` Borislav Petkov
2016-03-12 15:17 ` Ingo Molnar
2016-03-22 22:03 ` Maciej W. Rozycki
2016-03-12 15:08 ` Ingo Molnar
2016-03-12 15:12 ` Ingo Molnar
2016-03-12 15:16 ` [tip:x86/urgent] x86/fpu: Fix eager-FPU " tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457693438.2007.8.camel@nexus-software.ie \
--to=pure.logic@nexus-software.ie \
--cc=akpm@linux-foundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=yu-cheng.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).