From: Andreas Gruenbacher <agruenba@redhat.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Andreas Gruenbacher <agruenba@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
"Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
"J. Bruce Fields" <bfields@fieldses.org>,
Jeff Layton <jlayton@poochiereds.net>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
Dave Chinner <david@fromorbit.com>,
linux-ext4@vger.kernel.org, xfs@oss.sgi.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org,
linux-api@vger.kernel.org
Subject: [PATCH v19 10/23] posix_acl: Unexport acl_by_type and make it static
Date: Mon, 14 Mar 2016 15:55:09 +0100 [thread overview]
Message-ID: <1457967322-14886-11-git-send-email-agruenba@redhat.com> (raw)
In-Reply-To: <1457967322-14886-1-git-send-email-agruenba@redhat.com>
acl_by_type(inode, type) returns a pointer to either inode->i_acl or
inode->i_default_acl depending on type. This is useful in
fs/posix_acl.c, but should never have been visible outside that file.
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
fs/posix_acl.c | 3 +--
include/linux/posix_acl.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/posix_acl.c b/fs/posix_acl.c
index 711dd51..55f2445 100644
--- a/fs/posix_acl.c
+++ b/fs/posix_acl.c
@@ -21,7 +21,7 @@
#include <linux/export.h>
#include <linux/user_namespace.h>
-struct posix_acl **acl_by_type(struct inode *inode, int type)
+static struct posix_acl **acl_by_type(struct inode *inode, int type)
{
switch (type) {
case ACL_TYPE_ACCESS:
@@ -32,7 +32,6 @@ struct posix_acl **acl_by_type(struct inode *inode, int type)
BUG();
}
}
-EXPORT_SYMBOL(acl_by_type);
struct posix_acl *get_cached_acl(struct inode *inode, int type)
{
diff --git a/include/linux/posix_acl.h b/include/linux/posix_acl.h
index 3e96a6a..5b5a80c 100644
--- a/include/linux/posix_acl.h
+++ b/include/linux/posix_acl.h
@@ -99,7 +99,6 @@ extern int posix_acl_create(struct inode *, umode_t *, struct posix_acl **,
extern int simple_set_acl(struct inode *, struct posix_acl *, int);
extern int simple_acl_create(struct inode *, struct inode *);
-struct posix_acl **acl_by_type(struct inode *inode, int type);
struct posix_acl *get_cached_acl(struct inode *inode, int type);
struct posix_acl *get_cached_acl_rcu(struct inode *inode, int type);
void set_cached_acl(struct inode *inode, int type, struct posix_acl *acl);
--
2.5.0
next prev parent reply other threads:[~2016-03-14 14:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 14:54 [PATCH v19 00/23] Richacls (Core and Ext4) Andreas Gruenbacher
2016-03-14 14:55 ` [PATCH v19 01/23] vfs: Add IS_ACL() and IS_RICHACL() tests Andreas Gruenbacher
2016-03-14 14:55 ` [PATCH v19 02/23] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags Andreas Gruenbacher
2016-03-14 14:55 ` [PATCH v19 03/23] vfs: Add MAY_DELETE_SELF and MAY_DELETE_CHILD " Andreas Gruenbacher
2016-03-14 14:55 ` [PATCH v19 04/23] vfs: Make the inode passed to inode_change_ok non-const Andreas Gruenbacher
2016-03-14 14:55 ` [PATCH v19 05/23] vfs: Add permission flags for setting file attributes Andreas Gruenbacher
2016-03-14 14:55 ` [PATCH v19 06/23] richacl: In-memory representation and helper functions Andreas Gruenbacher
2016-03-14 14:55 ` [PATCH v19 07/23] richacl: Permission mapping functions Andreas Gruenbacher
2016-03-14 14:55 ` [PATCH v19 08/23] richacl: Compute maximum file masks from an acl Andreas Gruenbacher
2016-03-14 14:55 ` [PATCH v19 09/23] richacl: Permission check algorithm Andreas Gruenbacher
2016-03-14 14:55 ` Andreas Gruenbacher [this message]
2016-03-14 14:55 ` [PATCH v19 11/23] posix_acl: Improve xattr fixup code Andreas Gruenbacher
2016-03-14 14:55 ` [PATCH v19 12/23] vfs: Cache base_acl objects in inodes Andreas Gruenbacher
2016-03-14 14:55 ` [PATCH v19 13/23] vfs: Add get_richacl and set_richacl inode operations Andreas Gruenbacher
2016-03-14 14:55 ` [PATCH v19 14/23] vfs: Cache richacl in struct inode Andreas Gruenbacher
2016-03-14 14:55 ` [PATCH v19 15/23] richacl: Update the file masks in chmod() Andreas Gruenbacher
2016-03-14 14:55 ` [PATCH v19 16/23] richacl: Check if an acl is equivalent to a file mode Andreas Gruenbacher
2016-03-14 14:55 ` [PATCH v19 17/23] richacl: Create-time inheritance Andreas Gruenbacher
2016-03-14 14:55 ` [PATCH v19 18/23] richacl: Automatic Inheritance Andreas Gruenbacher
2016-03-14 14:55 ` [PATCH v19 19/23] richacl: xattr mapping functions Andreas Gruenbacher
2016-03-14 14:55 ` [PATCH v19 20/23] richacl: Add richacl xattr handler Andreas Gruenbacher
2016-03-14 14:55 ` [PATCH v19 21/23] vfs: Add richacl permission checking Andreas Gruenbacher
2016-03-14 14:55 ` [PATCH v19 22/23] ext4: Add richacl support Andreas Gruenbacher
2016-03-14 14:55 ` [PATCH v19 23/23] ext4: Add richacl feature flag Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457967322-14886-11-git-send-email-agruenba@redhat.com \
--to=agruenba@redhat.com \
--cc=adilger.kernel@dilger.ca \
--cc=anna.schumaker@netapp.com \
--cc=bfields@fieldses.org \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jlayton@poochiereds.net \
--cc=linux-api@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).