From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756371AbcCUNar (ORCPT ); Mon, 21 Mar 2016 09:30:47 -0400 Received: from swift.blarg.de ([78.47.110.205]:33195 "EHLO swift.blarg.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756129AbcCUNak (ORCPT ); Mon, 21 Mar 2016 09:30:40 -0400 Subject: [PATCH 3/6] drivers/media/media-devnode: clear private_data before put_device() From: Max Kellermann To: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Date: Mon, 21 Mar 2016 14:30:28 +0100 Message-ID: <145856702799.21117.16071591313990261661.stgit@woodpecker.blarg.de> In-Reply-To: <145856701730.21117.7759662061999658129.stgit@woodpecker.blarg.de> References: <145856701730.21117.7759662061999658129.stgit@woodpecker.blarg.de> User-Agent: StGit/0.17.1-16-g3c77 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Callbacks invoked from put_device() may free the struct media_devnode pointer, so any cleanup needs to be done before put_device(). Signed-off-by: Max Kellermann --- drivers/media/media-devnode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/media-devnode.c b/drivers/media/media-devnode.c index 4d7e8dd..e263816 100644 --- a/drivers/media/media-devnode.c +++ b/drivers/media/media-devnode.c @@ -196,10 +196,11 @@ static int media_release(struct inode *inode, struct file *filp) if (mdev->fops->release) mdev->fops->release(filp); + filp->private_data = NULL; + /* decrease the refcount unconditionally since the release() return value is ignored. */ put_device(&mdev->dev); - filp->private_data = NULL; return 0; }