* [PATCH] random: properly align get_random_int_hash
@ 2016-04-01 1:11 Eric Biggers
2016-05-05 1:08 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Eric Biggers @ 2016-04-01 1:11 UTC (permalink / raw)
To: linux-kernel; +Cc: arnd, gregkh, tytso, Eric Biggers
get_random_long() reads from the get_random_int_hash array using an
unsigned long pointer. For this code to be guaranteed correct on all
architectures, the array must be aligned to an unsigned long boundary.
Signed-off-by: Eric Biggers <ebiggers3@gmail.com>
---
drivers/char/random.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/char/random.c b/drivers/char/random.c
index b583e53..f867ef4 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -1792,13 +1792,15 @@ int random_int_secret_init(void)
return 0;
}
+static DEFINE_PER_CPU(__u32 [MD5_DIGEST_WORDS], get_random_int_hash)
+ __aligned(sizeof(unsigned long));
+
/*
* Get a random word for internal kernel use only. Similar to urandom but
* with the goal of minimal entropy pool depletion. As a result, the random
* value is not cryptographically secure but for several uses the cost of
* depleting entropy is too high
*/
-static DEFINE_PER_CPU(__u32 [MD5_DIGEST_WORDS], get_random_int_hash);
unsigned int get_random_int(void)
{
__u32 *hash;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] random: properly align get_random_int_hash
2016-04-01 1:11 [PATCH] random: properly align get_random_int_hash Eric Biggers
@ 2016-05-05 1:08 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2016-05-05 1:08 UTC (permalink / raw)
To: Eric Biggers; +Cc: linux-kernel, arnd, gregkh
On Thu, Mar 31, 2016 at 08:11:25PM -0500, Eric Biggers wrote:
> get_random_long() reads from the get_random_int_hash array using an
> unsigned long pointer. For this code to be guaranteed correct on all
> architectures, the array must be aligned to an unsigned long boundary.
>
> Signed-off-by: Eric Biggers <ebiggers3@gmail.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-05 1:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-01 1:11 [PATCH] random: properly align get_random_int_hash Eric Biggers
2016-05-05 1:08 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).