From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753026AbcDBRRe (ORCPT ); Sat, 2 Apr 2016 13:17:34 -0400 Received: from pygmy.kinoho.net ([134.0.27.24]:38052 "EHLO pygmy.kinoho.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751295AbcDBRRc (ORCPT ); Sat, 2 Apr 2016 13:17:32 -0400 X-Greylist: delayed 584 seconds by postgrey-1.27 at vger.kernel.org; Sat, 02 Apr 2016 13:17:32 EDT From: Grigori Goronzy To: Johan Hovold Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Grigori Goronzy Subject: [PATCH v2 13/14] USB: ch341: get rid of default configuration Date: Sat, 2 Apr 2016 19:07:22 +0200 Message-Id: <1459616843-23829-14-git-send-email-greg@chown.ath.cx> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1459616843-23829-1-git-send-email-greg@chown.ath.cx> References: <1459616843-23829-1-git-send-email-greg@chown.ath.cx> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the serial port hasn't been opened yet, no baud rate should be set and RTS/DTR need to be deasserted. Signed-off-by: Grigori Goronzy --- drivers/usb/serial/ch341.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c index 3b9a43d..6981e2ad 100644 --- a/drivers/usb/serial/ch341.c +++ b/drivers/usb/serial/ch341.c @@ -25,7 +25,6 @@ #include #include -#define DEFAULT_BAUD_RATE 9600 #define DEFAULT_TIMEOUT 1000 /* flags for IO-Bits */ @@ -235,10 +234,6 @@ static int ch341_configure(struct usb_device *dev, struct ch341_private *priv) if (r < 0) goto out; - r = ch341_init_set_baudrate(dev, priv, 0); - if (r < 0) - goto out; - r = ch341_set_handshake(dev, priv->line_control); if (r < 0) goto out; @@ -261,8 +256,6 @@ static int ch341_port_probe(struct usb_serial_port *port) return -ENOMEM; spin_lock_init(&priv->lock); - priv->baud_rate = DEFAULT_BAUD_RATE; - priv->line_control = CH341_BIT_RTS | CH341_BIT_DTR; r = ch341_configure(port->serial->dev, priv); if (r < 0) -- 1.9.1