From: Hari Bathini <hbathini@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>, linux-kernel@vger.kernel.org
Cc: fenghua.yu@intel.com, tony.luck@intel.com,
linux-ia64@vger.kernel.org, dyoung@redhat.com,
kexec@lists.infradead.org,
Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com>,
ebiederm@xmission.com, linuxppc-dev@lists.ozlabs.org,
vgoyal@redhat.com
Subject: Re: [PATCH v4 2/5] ia64: reuse append_elf_note() and final_note() functions
Date: Tue, 24 Jan 2017 23:38:29 +0530 [thread overview]
Message-ID: <145a745d-6035-d082-c088-432c7a918fcd@linux.vnet.ibm.com> (raw)
In-Reply-To: <87tw8umged.fsf@concordia.ellerman.id.au>
On Friday 20 January 2017 11:17 AM, Michael Ellerman wrote:
> Hari Bathini <hbathini@linux.vnet.ibm.com> writes:
>
>> Get rid of multiple definitions of append_elf_note() & final_note()
>> functions. Reuse these functions compiled under CONFIG_CRASH_CORE
>> Also, define Elf_Word and use it instead of generic u32 or the more
>> specific Elf64_Word.
>>
>> Signed-off-by: Hari Bathini <hbathini@linux.vnet.ibm.com>
>> ---
>>
>> Changes from v3:
>> * Dropped hard-coded values and used DIV_ROUND_UP().
>>
>> Changes from v2:
>> * Added a definition for Elf_Word.
>> * Used IA64 version of append_elf_note() and final_note() functions.
>>
>>
>> arch/ia64/kernel/crash.c | 22 ----------------------
>> include/linux/crash_core.h | 4 ++++
>> include/linux/elf.h | 2 ++
>> kernel/crash_core.c | 34 ++++++++++++++--------------------
>> kernel/kexec_core.c | 28 ----------------------------
>> 5 files changed, 20 insertions(+), 70 deletions(-)
> Do the powerpc patches later in the series actually depend on this one?
> Or is this just an unrelated cleanup?
>
> As it is I can't merge the series until we at least get an ack on this
> from the ia64 folks.
>
> If you can just split this out as a separate patch that would make it a
> lot easier to get the rest merged.
>
Hi Michael,
append_elf_note() & final_note() functions were defined statically at
three different places,
arch/powerpc/kernel/fadump.c being one of them. With my changes, I would
need to add
a fourth static definition if I ignore this cleanup. So, I preferred to
clean this up...
Let me ping IA64 folks one last time. Will do a respin without the
cleanup if I don't get
any response from them by end of this week..
Thanks
Hari
next prev parent reply other threads:[~2017-01-24 18:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 17:28 [PATCH v4 0/5] kexec/fadump: remove dependency with CONFIG_KEXEC and reuse crashkernel parameter for fadump Hari Bathini
2017-01-05 17:29 ` [PATCH v4 1/5] crash: move crashkernel parsing and vmcore related code under CONFIG_CRASH_CORE Hari Bathini
2017-01-06 2:02 ` Dave Young
2017-03-23 15:54 ` Hari Bathini
2017-01-05 17:31 ` [PATCH v4 2/5] ia64: reuse append_elf_note() and final_note() functions Hari Bathini
2017-01-06 2:03 ` Dave Young
2017-01-17 17:06 ` Hari Bathini
2017-01-24 18:11 ` Hari Bathini
2017-01-24 18:23 ` Tony Luck
2017-01-25 19:15 ` Hari Bathini
2017-01-31 22:21 ` Tony Luck
2017-02-01 1:11 ` Michael Ellerman
2017-01-20 5:47 ` Michael Ellerman
2017-01-24 18:08 ` Hari Bathini [this message]
2017-01-05 17:32 ` [PATCH v4 3/5] powerpc/fadump: remove dependency with CONFIG_KEXEC Hari Bathini
2017-01-13 11:27 ` Mahesh Jagannath Salgaonkar
2017-01-05 17:32 ` [PATCH v4 4/5] powerpc/fadump: reuse crashkernel parameter for fadump memory reservation Hari Bathini
2017-01-13 11:51 ` Mahesh Jagannath Salgaonkar
2017-01-05 17:32 ` [PATCH v4 5/5] powerpc/fadump: update documentation about crashkernel parameter reuse Hari Bathini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=145a745d-6035-d082-c088-432c7a918fcd@linux.vnet.ibm.com \
--to=hbathini@linux.vnet.ibm.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=fenghua.yu@intel.com \
--cc=kexec@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=tony.luck@intel.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).