From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751668AbcDQJWV (ORCPT ); Sun, 17 Apr 2016 05:22:21 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:57777 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751385AbcDQJWT (ORCPT ); Sun, 17 Apr 2016 05:22:19 -0400 From: Arnd Bergmann To: "David S. Miller" , Sabrina Dubroca Cc: Arnd Bergmann , Hannes Frederic Sowa , Johannes Berg , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] macsec: fix crypto Kconfig dependency Date: Sun, 17 Apr 2016 11:19:55 +0200 Message-Id: <1460884918-2879720-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:NgHi/HtKnAoGXp5SPL5hHpbBnkaTnok7fgEy4BYFnHojzSgKwrw AsBOTiIJIs7ce+iTqijML7XYE7CZEniTe/zz3aHtJ8XlchEgQntib46WUZe+YoJ/YBTps0T K0lefGVVTb8LptfzWirfQe5j27xVPIzjy1HLhwLCJpQNwD0xVL2C5Cni/qYrUpfDnFruOKF 86rtEtoOkuwgw3XcKxOww== X-UI-Out-Filterresults: notjunk:1;V01:K0:FUEEo+1/Eo8=:mdsjfEpCi/E/2gLTcSoTNn S7v6cojpqgCZ3FQrrVkLCoof0DAJqwX3gthiYnUgXgTM+JqceqCuix71tw3aVxGAk2r/z4ttq CRbDuSYzmy6kAO6AW+6ioCxFyDTeDXsfSMgBvyk+5V3ho0FXR1ZOTGrSALYeCi1CLFeTYgnY5 BopKVorjtPROXM9Krn5sjA7P51kHx1aCbU555iIyKZpPYLR8M9jsQh5rJRmtk3IEKoa2eTzsN WFv91xAgIxM5PeNRrMEYgoTzG24WBh+MS9D8q5/SJtlXVCWu5QvwPp9yeoN73ccfa7ZUdToi7 ml4Eig4BZ2o0HBsm1nZhq3b7TOoK4oBsZy90V3t1mqQFunpwNm46ubGmRncZQNRq0XgN1Y1Zz 4r0tMFF7oK0Lo+FoVivQO+i4tFu4vuRwVf9j39i7TiRX5mf7b3IVWht5zWu4ixy/XHCPtGucD rIoNDl0okdUkf7qbiPl7H7ogeVa3z4xTjzAoYaklYypQLQbqgASazeCBPyxun+NQhll02f6nn wUc6kzOiD+yFNQiRKgJ4amuXCklNZrJyfvVgkQhEnLafVytx4K5hBh3YnkoDdtUhU+yEJyqXP t2uingR7QCuDgmmcVcHSIcXkCWNZ+a2ppMr7aY1uA6042qFMlKaeL4wnrno8j2FHS+RrNqvnP RNJb56/pmUQFR/qYmY6mdyY0fsQH698IqH453xh7f21CNTagDq73qeYxdrbS5aABJUj0= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The new MACsec driver uses the AES crypto algorithm, but can be configured even if CONFIG_CRYPTO is disabled, leading to a build error: warning: (MAC80211 && MACSEC) selects CRYPTO_GCM which has unmet direct dependencies (CRYPTO) warning: (BT && CEPH_LIB && INET && MAC802154 && MAC80211 && BLK_DEV_RBD && MACSEC && AIRO_CS && LIBIPW && HOSTAP && USB_WUSB && RTLLIB_CRYPTO_CCMP && FS_ENCRYPTION && EXT4_ENCRYPTION && CEPH_FS && BIG_KEYS && ENCRYPTED_KEYS) selects CRYPTO_AES which has unmet direct dependencies (CRYPTO) crypto/built-in.o: In function `gcm_enc_copy_hash': aes_generic.c:(.text+0x2b8): undefined reference to `crypto_xor' aes_generic.c:(.text+0x2dc): undefined reference to `scatterwalk_map_and_copy' This adds an explicit 'select CRYPTO' statement the way that other drivers handle it. Signed-off-by: Arnd Bergmann Fixes: c09440f7dcb3 ("macsec: introduce IEEE 802.1AE driver") --- drivers/net/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 2a1ba62b7da2..a24c18eee598 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -195,6 +195,7 @@ config GENEVE config MACSEC tristate "IEEE 802.1AE MAC-level encryption (MACsec)" + select CRYPTO select CRYPTO_AES select CRYPTO_GCM ---help--- -- 2.7.0