linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Douglas Anderson <dianders@chromium.org>
To: ulf.hansson@linaro.org, jh80.chung@samsung.com
Cc: shawn.lin@rock-chips.com, adrian.hunter@intel.com,
	stefan@agner.ch, linux-mmc@vger.kernel.org,
	computersforpeace@gmail.com, dmitry.torokhov@gmail.com,
	Douglas Anderson <dianders@chromium.org>,
	justin.wang@spreadtrum.com, huangtao@rock-chips.com,
	lporzio@micron.com, ksumrall@android.com, jonathanh@nvidia.com,
	chuanxiao.dong@intel.com, linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] mmc: use SD/MMC host ID for block device name ID
Date: Thu, 28 Apr 2016 16:06:45 -0700	[thread overview]
Message-ID: <1461884805-29466-4-git-send-email-dianders@chromium.org> (raw)
In-Reply-To: <1461884805-29466-1-git-send-email-dianders@chromium.org>

From: Stefan Agner <stefan@agner.ch>

By using the SD/MMC host device ID as a starting point for block
device numbering, one can reliably predict the first block device
name (at least for the first controller). This is especially useful
for SoCs with multiple SD/MMC host controller, where the controller
with index 0 is connected to a eMMC device.

Usually the first controller gets the first block device name ID,
however this is not guaranteed. Also if the first controller is
aliased as second controller and visa-versa (using device tree
aliases), the block device name ID assignation is not ordered by
the SD/MMC host device ID (since mmc_rescan is called in order of
the memory mapped pheripherial addresses).

Signed-off-by: Stefan Agner <stefan@agner.ch>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
 drivers/mmc/card/block.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index 9fef7f04c4e6..bcf4fdbb5221 100644
--- a/drivers/mmc/card/block.c
+++ b/drivers/mmc/card/block.c
@@ -2215,7 +2215,8 @@ static struct mmc_blk_data *mmc_blk_alloc_req(struct mmc_card *card,
 	 * index anymore so we keep track of a name index.
 	 */
 	if (!subname) {
-		md->name_idx = find_first_zero_bit(name_use, max_devices);
+		md->name_idx = find_next_zero_bit(name_use, max_devices,
+				card->host->index);
 		__set_bit(md->name_idx, name_use);
 	} else
 		md->name_idx = ((struct mmc_blk_data *)
-- 
2.8.0.rc3.226.g39d4020

  parent reply	other threads:[~2016-04-28 23:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-28 23:06 [PATCH 0/3] Patches to allow consistent mmc / mmcblk numbering Douglas Anderson
2016-04-28 23:06 ` [PATCH 1/3] Documentation: mmc: Document mmc aliases Douglas Anderson
2016-04-28 23:06 ` [PATCH 2/3] mmc: read mmc alias from device tree Douglas Anderson
2016-04-28 23:06 ` Douglas Anderson [this message]
2016-04-29  2:18 ` [PATCH 0/3] Patches to allow consistent mmc / mmcblk numbering Jisheng Zhang
2016-04-29  7:21 ` Ulf Hansson
2016-04-29 17:32   ` Doug Anderson
2016-04-29 17:39 ` Arnd Bergmann
2016-05-10 11:09   ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461884805-29466-4-git-send-email-dianders@chromium.org \
    --to=dianders@chromium.org \
    --cc=adrian.hunter@intel.com \
    --cc=chuanxiao.dong@intel.com \
    --cc=computersforpeace@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=huangtao@rock-chips.com \
    --cc=jh80.chung@samsung.com \
    --cc=jonathanh@nvidia.com \
    --cc=justin.wang@spreadtrum.com \
    --cc=ksumrall@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=lporzio@micron.com \
    --cc=shawn.lin@rock-chips.com \
    --cc=stefan@agner.ch \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).