From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753362AbcD2Eta (ORCPT ); Fri, 29 Apr 2016 00:49:30 -0400 Received: from mail-pf0-f172.google.com ([209.85.192.172]:36325 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753068AbcD2Eqk (ORCPT ); Fri, 29 Apr 2016 00:46:40 -0400 From: David Carrillo-Cisneros To: Peter Zijlstra , Alexander Shishkin , Arnaldo Carvalho de Melo , Ingo Molnar Cc: Vikas Shivappa , Matt Fleming , Tony Luck , Stephane Eranian , Paul Turner , David Carrillo-Cisneros , x86@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 21/32] perf/x86/intel/cqm: handle inherit event and inherit_stat flag Date: Thu, 28 Apr 2016 21:43:27 -0700 Message-Id: <1461905018-86355-22-git-send-email-davidcc@google.com> X-Mailer: git-send-email 2.8.0.rc3.226.g39d4020 In-Reply-To: <1461905018-86355-1-git-send-email-davidcc@google.com> References: <1461905018-86355-1-git-send-email-davidcc@google.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since inherited events are part of the same cqm cache group, they share the RMID and therefore they cannot provide the granularity required by inherit_stats. Changing this would require to create a subtree of monrs for each parent event and its inherited events, a potential improvement for future patches. Reviewed-by: Stephane Eranian Signed-off-by: David Carrillo-Cisneros --- arch/x86/events/intel/cqm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/events/intel/cqm.c b/arch/x86/events/intel/cqm.c index d8d3191..6e85021 100644 --- a/arch/x86/events/intel/cqm.c +++ b/arch/x86/events/intel/cqm.c @@ -2483,6 +2483,7 @@ static int intel_cqm_event_init(struct perf_event *event) event->attr.exclude_idle || event->attr.exclude_host || event->attr.exclude_guest || + event->attr.inherit_stat || /* cqm groups share rmid */ event->attr.sample_period) /* no sampling */ return -EINVAL; -- 2.8.0.rc3.226.g39d4020