From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752895AbcD2Ho1 (ORCPT ); Fri, 29 Apr 2016 03:44:27 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:39529 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752652AbcD2Ho0 (ORCPT ); Fri, 29 Apr 2016 03:44:26 -0400 Message-ID: <1461915852.3521.3.camel@pengutronix.de> Subject: Re: [PATCH v3 2/2] dt-bindings: imx: ldb: Add ddc-i2c-bus property From: Philipp Zabel To: Rob Herring Cc: Akshay Bhat , airlied@linux.ie, steve_longerbeam@mentor.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 29 Apr 2016 09:44:12 +0200 In-Reply-To: <20160428214823.GA841@rob-hp-laptop> References: <1461788614-7784-1-git-send-email-akshay.bhat@timesys.com> <1461788614-7784-2-git-send-email-akshay.bhat@timesys.com> <20160428214823.GA841@rob-hp-laptop> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, den 28.04.2016, 16:48 -0500 schrieb Rob Herring: > On Wed, Apr 27, 2016 at 04:23:34PM -0400, Akshay Bhat wrote: > > Document the ddc-i2c-bus property used by imx-ldb driver to read EDID > > information via I2C interface. > > > > Signed-off-by: Akshay Bhat > > --- > > > > v3: > > Newly added. > > > > Documentation/devicetree/bindings/display/imx/ldb.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/display/imx/ldb.txt b/Documentation/devicetree/bindings/display/imx/ldb.txt > > index 0a175d9..a407462 100644 > > --- a/Documentation/devicetree/bindings/display/imx/ldb.txt > > +++ b/Documentation/devicetree/bindings/display/imx/ldb.txt > > @@ -62,6 +62,7 @@ Required properties: > > display-timings are used instead. > > > > Optional properties (required if display-timings are used): > > The required part doesn't make sense if you add this, but... > > > + - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing > > Really, this should be part of a connector node since i2c goes from the > i2c controller to a connector and is not part of the display controller. If the ddc i2c bus does indeed go through a connector, yes. Would that warrant a generic "lvds-connector" binding for all those different types of internal LVDS connectors? regards Philipp