From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932312AbcEFSM7 (ORCPT ); Fri, 6 May 2016 14:12:59 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:36379 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758152AbcEFSDf (ORCPT ); Fri, 6 May 2016 14:03:35 -0400 From: =?UTF-8?q?Matias=20Bj=C3=B8rling?= To: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, axboe@fb.com Cc: Jeff Mahoney , =?UTF-8?q?Matias=20Bj=C3=B8rling?= Subject: [PATCH 01/28] =?UTF-8?q?lightnvm:=20fix=20"warning:=20=E2=80=98re?= =?UTF-8?q?t=E2=80=99=20may=20be=20used=20uninitialized"?= Date: Fri, 6 May 2016 20:02:54 +0200 Message-Id: <1462557801-24974-2-git-send-email-m@bjorling.me> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1462557801-24974-1-git-send-email-m@bjorling.me> References: <1462557801-24974-1-git-send-email-m@bjorling.me> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jeff Mahoney This fixes the following warnings: drivers/lightnvm/sysblk.c:125:9: warning: ‘ret’ may be used uninitialized in this function drivers/lightnvm/sysblk.c:275:15: warning: ‘ret’ may be used uninitialized in this function In both cases, ret is only set from within a loop that may not be entered. Signed-off-by: Jeff Mahoney Reviewed-by: Johannes Thumshirn Signed-off-by: Matias Bjørling --- drivers/lightnvm/sysblk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/lightnvm/sysblk.c b/drivers/lightnvm/sysblk.c index 321de1f..b1e1404 100644 --- a/drivers/lightnvm/sysblk.c +++ b/drivers/lightnvm/sysblk.c @@ -122,7 +122,7 @@ static int nvm_get_all_sysblks(struct nvm_dev *dev, struct sysblk_scan *s, struct ppa_addr *ppas, nvm_bb_update_fn *fn) { struct ppa_addr dppa; - int i, ret; + int i, ret = 0; s->nr_ppas = 0; @@ -272,7 +272,7 @@ static int nvm_write_and_verify(struct nvm_dev *dev, struct nvm_sb_info *info, { struct nvm_system_block nvmsb; void *buf; - int i, sect, ret, bufsz; + int i, sect, ret = 0, bufsz; struct ppa_addr *ppas; nvm_cpu_to_sysblk(&nvmsb, info); -- 2.1.4