From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750997AbcEHSqR (ORCPT ); Sun, 8 May 2016 14:46:17 -0400 Received: from mga01.intel.com ([192.55.52.88]:50557 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750863AbcEHSqP (ORCPT ); Sun, 8 May 2016 14:46:15 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,597,1455004800"; d="scan'208";a="698790004" From: "Verma, Vishal L" To: "hch@infradead.org" CC: "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "xfs@oss.sgi.com" , "linux-nvdimm@ml01.01.org" , "jmoyer@redhat.com" , "linux-mm@kvack.org" , "Williams, Dan J" , "axboe@fb.com" , "akpm@linux-foundation.org" , "linux-fsdevel@vger.kernel.org" , "ross.zwisler@linux.intel.com" , "linux-ext4@vger.kernel.org" , "boaz@plexistor.com" , "Wilcox, Matthew R" , "david@fromorbit.com" , "jack@suse.cz" Subject: Re: [PATCH v5 3/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors Thread-Topic: [PATCH v5 3/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors Thread-Index: AQHRp+HM2eoEbh124kig/gT9Mjt4V5+vM12AgACmAoA= Date: Sun, 8 May 2016 18:46:13 +0000 Message-ID: <1462733173.3006.7.camel@intel.com> References: <1462571591-3361-1-git-send-email-vishal.l.verma@intel.com> <1462571591-3361-4-git-send-email-vishal.l.verma@intel.com> <20160508085203.GA10160@infradead.org> In-Reply-To: <20160508085203.GA10160@infradead.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.73.102] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u48IkO1e030825 On Sun, 2016-05-08 at 01:52 -0700, Christoph Hellwig wrote: > On Fri, May 06, 2016 at 03:53:09PM -0600, Vishal Verma wrote: > > > > From: Matthew Wilcox > > > > dax_clear_sectors() cannot handle poisoned blocks.  These must be > > zeroed using the BIO interface instead.  Convert ext2 and XFS to > > use > > only sb_issue_zerout(). > > > > Signed-off-by: Matthew Wilcox > > [vishal: Also remove the dax_clear_sectors function entirely] > > Signed-off-by: Vishal Verma > Just to make sure:  the existing sb_issue_zerout as in 4.6-rc > is already doing the right thing for DAX?  I've got a pending > patchset > for XFS that introduces another dax_clear_sectors users, but if it's > already safe to use blkdev_issue_zeroout I can switch to that and > avoid > the merge conflict. I believe so - Jan has moved all unwritten extent conversions out of DAX with his patch set, and I believe zeroing through the driver is always fine. Ross or Jan could confirm though.