From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751552AbcEJHt2 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 10 May 2016 03:49:28 -0400
Received: from mx2.suse.de ([195.135.220.15]:55320 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751209AbcEJHtZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 10 May 2016 03:49:25 -0400
Message-ID: <1462866562.3702.33.camel@suse.de>
Subject: Re: sched: tweak select_idle_sibling to look for idle threads
From: Mike Galbraith <mgalbraith@suse.de>
To: Yuyang Du <yuyang.du@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Chris Mason <clm@fb.com>,
        Ingo Molnar <mingo@kernel.org>,
        Matt Fleming <matt@codeblueprint.co.uk>, linux-kernel@vger.kernel.org
Date: Tue, 10 May 2016 09:49:22 +0200
In-Reply-To: <20160509232623.GR16093@intel.com>
References: <20160501085303.GF2975@worktop.cust.blueprintrf.com>
	 <1462094425.9717.45.camel@suse.de> <20160507012417.GK16093@intel.com>
	 <1462694935.4155.83.camel@suse.de> <20160508185747.GL16093@intel.com>
	 <1462765540.3803.44.camel@suse.de> <20160508202201.GM16093@intel.com>
	 <1462779853.3803.128.camel@suse.de> <20160509011311.GQ16093@intel.com>
	 <1462786745.3803.181.camel@suse.de> <20160509232623.GR16093@intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.16.5 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2016-05-10 at 07:26 +0800, Yuyang Du wrote:

> By cpu reservation, you mean the various averages in select_task_rq_fair?
> It does seem a lot of cleanup should be done.

Nah, I meant claiming an idle cpu with cmpxchg().  It's mostly the
average load business that leads to premature stacking though, the
reservation thingy more or less just wastes cycles.  Only whacking
cfs_rq_runnable_load_avg() with a rock makes schbench -m <sockets> -t
<near socket size> -a work well.  'Course a rock in its gearbox also
rendered load balancing fairly busted for the general case :)

	-Mike