From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 02/15] perf stat: Scale values by unit before metrics
Date: Tue, 10 May 2016 12:15:12 -0300 [thread overview]
Message-ID: <1462893325-28646-3-git-send-email-acme@kernel.org> (raw)
In-Reply-To: <1462893325-28646-1-git-send-email-acme@kernel.org>
From: Andi Kleen <ak@linux.intel.com>
Scale values by unit before passing them to the metrics printing
functions. This is needed for TopDown, because it needs to scale the
slots correctly by pipeline width / SMTness.
For existing metrics it shouldn't make any difference, as those
generally use events that don't have any units.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1462489447-31832-8-git-send-email-andi@firstfloor.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/stat.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c
index 4d9b481cf3b6..ffa1d0653861 100644
--- a/tools/perf/util/stat.c
+++ b/tools/perf/util/stat.c
@@ -307,6 +307,7 @@ int perf_stat_process_counter(struct perf_stat_config *config,
struct perf_counts_values *aggr = &counter->counts->aggr;
struct perf_stat_evsel *ps = counter->priv;
u64 *count = counter->counts->aggr.values;
+ u64 val;
int i, ret;
aggr->val = aggr->ena = aggr->run = 0;
@@ -346,7 +347,8 @@ int perf_stat_process_counter(struct perf_stat_config *config,
/*
* Save the full runtime - to allow normalization during printout:
*/
- perf_stat__update_shadow_stats(counter, count, 0);
+ val = counter->scale * *count;
+ perf_stat__update_shadow_stats(counter, &val, 0);
return 0;
}
--
2.5.5
next prev parent reply other threads:[~2016-05-10 15:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 15:15 [GIT PULL 00/15] perf/core improvements and fixes Arnaldo Carvalho de Melo
2016-05-10 15:15 ` [PATCH 01/15] perf callchain: Recording 'dwarf' callchains do not need DWARF unwinding support Arnaldo Carvalho de Melo
2016-05-10 15:15 ` Arnaldo Carvalho de Melo [this message]
2016-05-10 15:15 ` [PATCH 03/15] perf script: Fix incorrect python db-export error message Arnaldo Carvalho de Melo
2016-05-10 15:15 ` [PATCH 04/15] perf tools: Support reading from backward ring buffer Arnaldo Carvalho de Melo
2016-05-10 15:15 ` [PATCH 05/15] perf tests: Add test to check " Arnaldo Carvalho de Melo
2016-05-10 15:15 ` [PATCH 06/15] perf evsel: Print state of perf_event_attr.write_backward Arnaldo Carvalho de Melo
2016-05-10 15:15 ` [PATCH 07/15] perf symbols: Fix handling of zero-length symbols Arnaldo Carvalho de Melo
2016-05-10 15:15 ` [PATCH 08/15] perf tools: Rewrite strbuf not to die() Arnaldo Carvalho de Melo
2016-05-10 15:15 ` [PATCH 09/15] perf probe: Check the return value of strbuf APIs Arnaldo Carvalho de Melo
2016-05-10 15:15 ` [PATCH 10/15] perf help: Make check_emacsclient_version to check " Arnaldo Carvalho de Melo
2016-05-10 15:15 ` [PATCH 11/15] perf tools: Make alias handler to check return value of strbuf Arnaldo Carvalho de Melo
2016-05-10 15:15 ` [PATCH 12/15] perf header: Make topology checkers " Arnaldo Carvalho de Melo
2016-05-10 15:15 ` [PATCH 13/15] perf pmu: Make pmu_formats_string " Arnaldo Carvalho de Melo
2016-05-10 15:15 ` [PATCH 14/15] perf help: Do not use ALLOC_GROW in add_cmd_list Arnaldo Carvalho de Melo
2016-05-10 15:15 ` [PATCH 15/15] perf tools: Remove xrealloc and ALLOC_GROW Arnaldo Carvalho de Melo
2016-05-10 20:28 ` [GIT PULL 00/15] perf/core improvements and fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462893325-28646-3-git-send-email-acme@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).