From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932496AbcELTuD (ORCPT ); Thu, 12 May 2016 15:50:03 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:38304 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932248AbcELTt6 (ORCPT ); Thu, 12 May 2016 15:49:58 -0400 From: Matt Fleming To: Peter Zijlstra , Ingo Molnar Cc: linux-kernel@vger.kernel.org, Byungchul Park , Frederic Weisbecker , Luca Abeni , "Rafael J . Wysocki" , Rik van Riel , Thomas Gleixner , Wanpeng Li , Yuyang Du , Mel Gorman , Mike Galbraith , Matt Fleming Subject: [RFC][PATCH 1/5] sched/fair: Update the rq clock before detaching tasks Date: Thu, 12 May 2016 20:49:49 +0100 Message-Id: <1463082593-27777-2-git-send-email-matt@codeblueprint.co.uk> X-Mailer: git-send-email 2.7.3 In-Reply-To: <1463082593-27777-1-git-send-email-matt@codeblueprint.co.uk> References: <1463082593-27777-1-git-send-email-matt@codeblueprint.co.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org detach_task_cfs_rq() may indirectly call rq_clock() to inform the cpufreq code that the rq utilisation has changed. In which case, we need to update the rq clock. Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Mel Gorman Cc: Mike Galbraith Cc: Yuyang Du Cc: Byungchul Park Cc: Rik van Riel Cc: Frederic Weisbecker Signed-off-by: Matt Fleming --- kernel/sched/fair.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 218f8e83db73..02856647339d 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8378,6 +8378,8 @@ static void detach_task_cfs_rq(struct task_struct *p) struct sched_entity *se = &p->se; struct cfs_rq *cfs_rq = cfs_rq_of(se); + update_rq_clock(task_rq(p)); + if (!vruntime_normalized(p)) { /* * Fix up our vruntime so that the current sleep doesn't -- 2.7.3