From: Vignesh R <vigneshr@ti.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Lee Jones <lee.jones@linaro.org>
Cc: Vignesh R <vigneshr@ti.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Dave Gerlach <d-gerlach@ti.com>, <linux-input@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH 3/3] Input: ti_am335x_tsc - Ack pending IRQs at probe and before suspend
Date: Mon, 16 May 2016 16:56:24 +0530 [thread overview]
Message-ID: <1463397984-15766-4-git-send-email-vigneshr@ti.com> (raw)
In-Reply-To: <1463397984-15766-1-git-send-email-vigneshr@ti.com>
From: Grygorii Strashko <grygorii.strashko@ti.com>
It is seen that just enabling the TSC module triggers a HW_PEN IRQ
without any interaction with touchscreen by user. This results in first
suspend/resume sequence to fail as system immediately wakes up from
suspend as soon as HW_PEN IRQ is enabled in suspend handler. due to the
pending IRQ. Therefore clear all IRQs at probe and also in suspend
callback for sanity.
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Vignesh R <vigneshr@ti.com>
---
drivers/input/touchscreen/ti_am335x_tsc.c | 2 ++
include/linux/mfd/ti_am335x_tscadc.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
index 4683ed18b9f8..d2c55b5730e6 100644
--- a/drivers/input/touchscreen/ti_am335x_tsc.c
+++ b/drivers/input/touchscreen/ti_am335x_tsc.c
@@ -441,6 +441,7 @@ static int titsc_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "irq wake enable failed.\n");
}
+ titsc_writel(ts_dev, REG_IRQSTATUS, IRQENB_MASK);
titsc_writel(ts_dev, REG_IRQENABLE, IRQENB_FIFO0THRES);
titsc_writel(ts_dev, REG_IRQENABLE, IRQENB_EOS);
err = titsc_config_wires(ts_dev);
@@ -506,6 +507,7 @@ static int __maybe_unused titsc_suspend(struct device *dev)
tscadc_dev = ti_tscadc_dev_get(to_platform_device(dev));
if (device_may_wakeup(tscadc_dev->dev)) {
+ titsc_writel(ts_dev, REG_IRQSTATUS, IRQENB_MASK);
idle = titsc_readl(ts_dev, REG_IRQENABLE);
titsc_writel(ts_dev, REG_IRQENABLE,
(idle | IRQENB_HW_PEN));
diff --git a/include/linux/mfd/ti_am335x_tscadc.h b/include/linux/mfd/ti_am335x_tscadc.h
index 1fd50dcfe47c..a7ca0f908ba8 100644
--- a/include/linux/mfd/ti_am335x_tscadc.h
+++ b/include/linux/mfd/ti_am335x_tscadc.h
@@ -60,6 +60,7 @@
#define IRQENB_FIFO1OVRRUN BIT(6)
#define IRQENB_FIFO1UNDRFLW BIT(7)
#define IRQENB_PENUP BIT(9)
+#define IRQENB_MASK (0x7FF)
/* Step Configuration */
#define STEPCONFIG_MODE_MASK (3 << 0)
--
2.8.2
next prev parent reply other threads:[~2016-05-16 11:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 11:26 [PATCH 0/3] AM335x: tsc: Fix suspended while touchscreen in use Vignesh R
2016-05-16 11:26 ` [PATCH 1/3] Input: ti_am335x_tsc - Mark IRQ as wakeup capable Vignesh R
2016-05-16 19:46 ` Dmitry Torokhov
2016-05-17 10:14 ` Vignesh R
2016-05-16 11:26 ` [PATCH 2/3] Input: ti_am335x_tsc - Prevent system suspend when TSC is in use Vignesh R
2016-05-16 11:26 ` Vignesh R [this message]
2016-05-16 19:44 ` [PATCH 3/3] Input: ti_am335x_tsc - Ack pending IRQs at probe and before suspend Dmitry Torokhov
2016-05-17 5:56 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463397984-15766-4-git-send-email-vigneshr@ti.com \
--to=vigneshr@ti.com \
--cc=d-gerlach@ti.com \
--cc=dmitry.torokhov@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).