From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932579AbcEQFI1 (ORCPT ); Tue, 17 May 2016 01:08:27 -0400 Received: from exsmtp01.microchip.com ([198.175.253.37]:22125 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932369AbcEQFIY (ORCPT ); Tue, 17 May 2016 01:08:24 -0400 From: Purna Chandra Mandal To: CC: , Ralf Baechle , Joshua Henderson , Purna Chandra Mandal , Jason Cooper , Thomas Gleixner , Marc Zyngier Subject: [PATCH 04/11] irqchip: irq-pic32-evic: Fix bug with external interrupts. Date: Tue, 17 May 2016 10:35:53 +0530 Message-ID: <1463461560-9629-4-git-send-email-purna.mandal@microchip.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1463461560-9629-1-git-send-email-purna.mandal@microchip.com> References: <1463461560-9629-1-git-send-email-purna.mandal@microchip.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joshua Henderson The wrong external interrupt bits are being set, offset by 1. Signed-off-by: Joshua Henderson Signed-off-by: Purna Chandra Mandal --- drivers/irqchip/irq-pic32-evic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-pic32-evic.c b/drivers/irqchip/irq-pic32-evic.c index e7155db..73addb4 100644 --- a/drivers/irqchip/irq-pic32-evic.c +++ b/drivers/irqchip/irq-pic32-evic.c @@ -91,7 +91,7 @@ static int pic32_set_type_edge(struct irq_data *data, /* set polarity for external interrupts only */ for (i = 0; i < ARRAY_SIZE(priv->ext_irqs); i++) { if (priv->ext_irqs[i] == data->hwirq) { - ret = pic32_set_ext_polarity(i + 1, flow_type); + ret = pic32_set_ext_polarity(i, flow_type); if (ret) return ret; } -- 1.8.3.1